Enable a11y browser tests depending on takeFocus for Fission
Categories
(Core :: Disability Access APIs, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: cpeterson, Assigned: Jamie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
a11y mochitest status as of 2019-12-10:
| Test | Opt Status | Debug Status |
|---|---|---|
| accessible/tests/browser/e10s/browser_caching_attributes.js | skipped | skipped |
| accessible/tests/browser/e10s/browser_caching_value.js | skipped | skipped |
| accessible/tests/browser/e10s/browser_events_caretmove.js | skipped | skipped |
| accessible/tests/browser/e10s/browser_treeupdate_select_dropdown.js | skipped | skipped |
Jamie says these tests are blocked on SetFocus bug 1556627.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
Reporter | |
Comment 1•5 years ago
|
||
Jamie says this bug depends on DOM bug 1556627, which is actively being worked on. Once that gets fixed, Jamie can assign this bug based on availability at the time; it should hopefully just be a matter of enabling the tests.
|
|
Reporter | |
Comment 2•5 years ago
|
||
Jamie, just a heads up: nsFocusManager::SetFocus bug 1556627 has been fixed, so you might now be able to re-enable the a11y browser tests that depend on takeFocus.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Unfortunately, I get a whole stack of failures when I re-enable them. I'm looking into it further, but I think more work is going to be needed here. :(
|
|
Assignee | |
Comment 4•5 years ago
|
||
Turns out most of the failures I was seeing were somehow related to AccessibleHandler. That's not ideal, but it's also not Fission specific.
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 6•5 years ago
|
||
nsFocusManager::SetFocus (and thus Accessible::TakeFocus) was fixed for Fission in bug 1556627.
Most of these tests now pass without modification.
browser_caching_value.js needed to be tweaked slightly to synthesize a key in the OOP iframe instead of the top level document.
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Description
•