Opening Findbar broke contenteditable caret moving
Categories
(Core :: Find Backend, defect, P1)
Tracking
()
People
(Reporter: jacekbogd, Assigned: enndeakin)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36
Steps to reproduce:
The issue seems to be reproducible from 71.0 Firefox version (tested on Windows 10).
- Open any page sample with contenteditable element. You can use https://codepen.io/jacekbogdanski/pen/QWwNOoV
- Open FF search bar using CTRL + F keyboard combination.
- Focus contenteditable element.
- Start navigating using keyboard arrow keys.
Keyboard navigation works fine until you open a search bar. The issue didn't occur on Firefox 70.
Actual results:
It is possible to use all keys even if the search bar of Firefox is opened.
Expected results:
It is not able to move a caret.
Comment 1•5 years ago
|
||
I can reproduce the issue on Nightly63.0a1 Windows10 as well as Firefox71.
STR:
- Open any page sample with contenteditable element. You can use https://codepen.io/jacekbogdanski/pen/QWwNOoV
- Focus contenteditable element by mouse click.
- Open Findbar using CTRL + F keyboard combination.
--- The caret can be moved to left and right with the left/right arrow keys. OK - Focus contenteditable element again.
- Start navigating using keyboard arrow keys.
--- It is not able to move a caret. BUG
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5b303cb0a0a39e2bd4a6fea53535fe8e1d829b97&tochange=e33c3e14ee40f88d1775952e309dc2a617eb97f7
Comment 2•5 years ago
|
||
[Tracking Requested - why for this release]:Mail compose window Yahoo! Japan is also affected if Findbar is opened
Also affected to https://mail.yahoo.co.jp/ compose window
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Too late for 71.
Comment 4•5 years ago
|
||
Hi Mike, can you please take a look at this while Neil is on PTO?
Assignee | ||
Comment 5•5 years ago
|
||
I can't reproduce this bug at all.
Comment 6•5 years ago
|
||
I can still reproduce the issue with STR Comment#1 on Nightly73.0a1(20191222215627) Windows10.
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Also affected to https://ckeditor.com/latest/samples/index.html
Comment 8•5 years ago
|
||
Tentatively assigning to Neil because he said planned to investigate these findbar regressions next week, unless Mike makes progress before then.
Tracking for Fission dogfooding (M5)
Updated•5 years ago
|
Comment 9•5 years ago
|
||
I can reproduce this bug in both Fission and non-Fission mode. Caret navigation is broken even after closing the Findbar.
We don't need to track this bug for Fission since non-Fission mode is also broken.
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 10•5 years ago
|
||
Assignee | ||
Comment 11•5 years ago
|
||
Depends on D58990
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9a8af38a964f
https://hg.mozilla.org/mozilla-central/rev/3f585af46d39
Comment 14•5 years ago
|
||
I can reproduce the issue on Nightly74.0a1(20200120094216) Windows10.
And I verified that the issue was fixed in Nightly74.0a1(20200121093246).
Comment 15•5 years ago
|
||
Please nominate this for Beta approval when you get a chance.
Assignee | ||
Comment 16•5 years ago
|
||
Comment on attachment 9119183 [details]
Bug 1603020, send state update messages to all child actors, r=mikedeboer
Beta/Release Uplift Approval Request
- User impact if declined: After opening the findbar, typing/moving the caret does not work in some contenteditable fields
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky):
- String changes made/needed: None
Assignee | ||
Updated•5 years ago
|
Comment 17•5 years ago
|
||
Comment on attachment 9119183 [details]
Bug 1603020, send state update messages to all child actors, r=mikedeboer
regression fix, approved for 73.0b11
Updated•5 years ago
|
Comment 18•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Comment 19•5 years ago
|
||
Reproduced the initial issue using Release version 72.0.2.
Verified - Fixed in latest Beta 73.0b11 (Build id: 20200128001646) using Windows 10.
Description
•