Remove unused declaration in U2F.cpp
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Tracking
(firefox74 fixed)
Tracking | Status | |
---|---|---|
firefox74 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: mbansal, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(4 files, 5 obsolete files)
Filling as a good first bug to learn workflows.
These line seems to be unused:
https://searchfox.org/mozilla-central/source/dom/u2f/U2F.cpp#34
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by clang diag https://clang.llvm.org/docs/DiagnosticsReference.html#wunused-variable
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Comment hidden (obsolete) |
Comment 2•5 years ago
|
||
Who do I put in the reviewer tag, i.e. "r="?
Reporter | ||
Comment 3•5 years ago
|
||
(In reply to Mahak from comment #1)
according to the link, to clone the repo I used 'hg clone https://hg.mozilla.org/mozilla-central/' this command but this command does not contain the repo of given issue .
Sorry but I don't understand what you mean here?!
Reporter | ||
Comment 4•5 years ago
|
||
Who do I put in the reviewer tag, i.e. "r="?
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Updated•5 years ago
|
(In reply to Sylvestre Ledru [:Sylvestre] from comment #4)
Who do I put in the reviewer tag, i.e. "r="?
Sir ,
I fixed the bug but why it is assigned to someone else ?
And Also I'm not able to find who is the reviewer .
Please help
Updated•5 years ago
|
Comment 9•5 years ago
|
||
Reporter | ||
Comment 10•5 years ago
|
||
I fixed the bug but why it is assigned to someone else ?
Not sure. I set you as owner.
Ash, please don't take ongoing bugs from others. If you want another good first bug, please let me an email.
And Also I'm not able to find who is the reviewer ?
hg log will tell you
Updated•5 years ago
|
Comment hidden (obsolete) |
Comment 12•5 years ago
|
||
Bug 1603100 removes the unused line r?Andrew Halberstadt
Updated•5 years ago
|
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Depends on D57059
Comment 14•5 years ago
|
||
Sir,
I did use hg log and it displayed all the commits but how will I distinguish the reviewer from others ..
Could you please help me.
Reporter | ||
Comment 15•5 years ago
|
||
Mahak,
I am really sorry but I don't think you are ready yet to contribute to Firefox. All the information that you need to contribute are referenced on the doc.
I think you should probably start with easier projects (for example, hosted on github). Firefox isn't a trivial project to start contributing.
I unassigned the bug to you.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 16•5 years ago
|
||
(In reply to Sylvestre Ledru [:Sylvestre] from comment #15)
Mahak,
I am really sorry but I don't think you are ready yet to contribute to Firefox. All the information that you need to contribute are referenced on the doc.
I think you should probably start with easier projects (for example, hosted on github). Firefox isn't a trivial project to start contributing.I unassigned the bug to you.
Sir,
I understand what you are saying and I respect that you have answered so many silly questions.
I thank you for all and just want to ask from where should I start to contribute to open source and what are easy github projects ?
Comment 17•5 years ago
|
||
(In reply to Mahak from comment #16)
(In reply to Sylvestre Ledru [:Sylvestre] from comment #15)
Mahak,
I am really sorry but I don't think you are ready yet to contribute to Firefox. All the information that you need to contribute are referenced on the doc.
I think you should probably start with easier projects (for example, hosted on github). Firefox isn't a trivial project to start contributing.I unassigned the bug to you.
Sir,
I understand what you are saying and I respect that you have answered so many silly questions.
I thank you for all and just want to ask from where should I start to contribute to open source and what are easy github projects ?
If I may, https://github.com/MunGell/awesome-for-beginners could help. Very beginner-friendly.
Updated•5 years ago
|
Assignee | ||
Comment 18•5 years ago
|
||
Assignee | ||
Comment 19•5 years ago
|
||
I have submitted a patch as I thought No one was working on this .
I request for the review
Reporter | ||
Comment 20•5 years ago
|
||
Assignee | ||
Comment 21•5 years ago
|
||
I have used the process given in the doc and have used phabricator.
Could you please point out where I'm going wrong?
Reporter | ||
Comment 22•5 years ago
|
||
Not sure how you did that wrong
but https://bug1603100.bmoattachments.org/attachment.cgi?id=9123966 is a bugzilla attachement, not a phab review
Assignee | ||
Comment 23•5 years ago
|
||
Assignee | ||
Comment 24•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 25•5 years ago
|
||
I guess I have made the required changes .
@Sylvestre can you please review it?
Comment 26•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 27•5 years ago
|
||
Thanks for the Motivation @sylvestre .
I just want to know when I show this as my contribution ,Does this make a difference that it is assigned to someone else?
Comment 28•5 years ago
|
||
bugherder |
Comment 29•5 years ago
|
||
(In reply to Mahak from comment #27)
Thanks for the Motivation @sylvestre .
I just want to know when I show this as my contribution ,Does this make a difference that it is assigned to someone else?
Phabricator automatically updated the assignee based on the patches that were uploaded on phabricator at that time. Restoring the field to the correct value.
Updated•5 years ago
|
Updated•2 years ago
|
Description
•