Closed Bug 1603389 Opened 5 years ago Closed 5 years ago

"Show Content Messages" checkbox is reinitialized in the Omniscient Browser Toolbox after every restart

Categories

(DevTools :: Console, task, P3)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
Firefox 73
Tracking Status
firefox73 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

STRs:

  • open OBT, open console
  • in the Console cog options, disable "Show Content Messages"
  • close the OBT
  • open OBT, open console

Expected Result: The setting should be persisted, "Show Content Messages" should be disabled
Actual Result: The setting is enabled again.

Note: this only applies to this setting. Timestamp and grouping options are correctly persisted across restarts.

Probably from this code that initializes the state of the console

showContentMessages: webConsoleUI.isBrowserConsole
        ? getBoolPref(PREFS.UI.CONTENT_MESSAGES)
        : true,

To be clear this should be updated to check webConsoleUI.isBrowserConsole || isBrowserToolbox (the catch is that we don't have a good isBrowserToolbox helper available I think)

Actually the console has webConsoleUI.isBrowserToolboxConsole which should be perfect here!

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Nicolas, what do you think should be the default behavior of the Browser Toolbox Console? Should it show content messages by default or not?
Today, with the current code, the setting is always true on startup. If we change it to have the same logic as the Browser Console, then by default content messages will be hidden.

We can either:

  • keep it disabled by default and update browser_toolbox_console_new_process.js to set the pref in the BT profile
  • update the default value of devtools.browserconsole.contentMessages to be true (will then change the default behavior of the Browser Console)
  • default it to true only for the Browser Toolbox Console (would be consistent with the current situation, but might be hard to justify)
Flags: needinfo?(nchevobbe)
Attachment #9115425 - Attachment description: Bug 1603389 - Read content messages setting from prefs for BrowserToolbox Console, and default to true → Bug 1603389 - Read content messages setting from prefs for BrowserToolbox Console, and default to true for Browser Toolbox

I'd say let's keep it disabled to match the Browser Console logic.

Flags: needinfo?(nchevobbe)

sounds good, thanks!

Attachment #9115425 - Attachment is obsolete: true
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/45777f13e11a Read content-process messages setting from prefs for BrowserToolbox Console r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: