History Sidebar view mode is initialized when update today's Nightly
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox71 | --- | unaffected |
firefox72 | --- | unaffected |
firefox73 | + | fixed |
firefox74 | --- | verified |
People
(Reporter: alice0775, Assigned: emmamalysz)
References
(Regression)
Details
(Keywords: nightly-community, regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
[Tracking Requested - why for this release]: Regular update should not change user settings
Reproducible: once update from 20191210095443 to 20191211094640
Steps To Reproduce
- Start Nightly Build ID 20191210095443
- Open History Sidebar Ctrl+H
- Change View for example from By Date to By Last Visited
- Quit browser
- Start Nightly Build ID 20191211094640 with same profile of step1
--- observe History Sidebar view mode
Actual Results:
History Sidebar view mode is inotialized, i.e, "By Date" instead of previous mode
Expected Results:
History Sidebar view mode should not be changed when regular update.
![]() |
Reporter | |
Comment 1•5 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5fd7ad835de62e94f7c6a011671a1eda92ba4ca7&tochange=23c591259da010fe4857703af04a6b90458f91de
![]() |
Reporter | |
Updated•5 years ago
|
Comment 2•5 years ago
|
||
We probably need to do a ui migration for xulstore (like this https://searchfox.org/mozilla-central/rev/62a130ba0ac80f75175e4b65536290b52391f116/browser/components/BrowserGlue.jsm#3143-3148) for the relevant document (chrome://browser/content/places/historySidebar.xul -> chrome://browser/content/places/historySidebar.xhtml).
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
![]() |
Reporter | |
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Looks like the patch here will fix bug 1603514; bug 1603514 is not a regression of this bug.
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77a6b0692510 Migrate XULStore for places, historySidebar, and bookmarksSidebar values to the new xhtml paths r=bgrins
Comment 7•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 8•5 years ago
|
||
I've reproduced this issue with the Nightly builds mentioned in bug description. I confirm that the issue is fixed with the latest Nightly 74.0a1(2020-01-30) across platforms. Since this issue occurred only on 73 version (nightly version at that time), beta verification is not necessary conclusive, but I ran a quick check with an older beta to the latest version Fx 73.0b12 and the previous setting stays in place.
Updated•3 years ago
|
Description
•