Closed Bug 1603457 Opened 5 years ago Closed 5 years ago

History Sidebar view mode is initialized when update today's Nightly

Categories

(Firefox :: Bookmarks & History, defect)

73 Branch
Desktop
Windows 10
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 73
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- unaffected
firefox72 --- unaffected
firefox73 + fixed
firefox74 --- verified

People

(Reporter: alice0775, Assigned: emmamalysz)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(1 file)

[Tracking Requested - why for this release]: Regular update should not change user settings

Reproducible: once update from 20191210095443 to 20191211094640

Steps To Reproduce

  1. Start Nightly Build ID 20191210095443
  2. Open History Sidebar Ctrl+H
  3. Change View for example from By Date to By Last Visited
  4. Quit browser
  5. Start Nightly Build ID 20191211094640 with same profile of step1
    --- observe History Sidebar view mode

Actual Results:
History Sidebar view mode is inotialized, i.e, "By Date" instead of previous mode

Expected Results:
History Sidebar view mode should not be changed when regular update.

Summary: History Sidebar view mode is initialized when update today's Nightly update → History Sidebar view mode is initialized when update today's Nightly

We probably need to do a ui migration for xulstore (like this https://searchfox.org/mozilla-central/rev/62a130ba0ac80f75175e4b65536290b52391f116/browser/components/BrowserGlue.jsm#3143-3148) for the relevant document (chrome://browser/content/places/historySidebar.xul -> chrome://browser/content/places/historySidebar.xhtml).

Assignee: nobody → emalysz
Status: NEW → ASSIGNED

Bug 1603514 is related here.

Regressions: 1603514
Attachment #9115595 - Attachment description: Bug 1603457, ensure History Sidebar view mode is initialized correctly by migrating the relevant xul document → Bug 1603457, Migrate places, XULStore, and bookmarksSidebar values to the new xhtml paths

Looks like the patch here will fix bug 1603514; bug 1603514 is not a regression of this bug.

Blocks: 1603514
No longer regressions: 1603514
Attachment #9115595 - Attachment description: Bug 1603457, Migrate places, XULStore, and bookmarksSidebar values to the new xhtml paths → Bug 1603457, Migrate XULStore for places, historySidebar, and bookmarksSidebar values to the new xhtml paths
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77a6b0692510
Migrate XULStore for places, historySidebar, and  bookmarksSidebar values to the new xhtml paths r=bgrins
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
Flags: qe-verify+

I've reproduced this issue with the Nightly builds mentioned in bug description. I confirm that the issue is fixed with the latest Nightly 74.0a1(2020-01-30) across platforms. Since this issue occurred only on 73 version (nightly version at that time), beta verification is not necessary conclusive, but I ran a quick check with an older beta to the latest version Fx 73.0b12 and the previous setting stays in place.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: