Closed
Bug 1603527
Opened 5 years ago
Closed 5 years ago
Support `Stop` key event in `MediaControlKeysHandler`
Categories
(Core :: Audio/Video: Playback, task, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(2 files, 1 obsolete file)
As currently we only support controlling media on OSX, which won't send MediaControlActions::eStop, we haven't supported that in MediaControlKeysHandler yet.
However, it would be needed in the implementation on other platforms.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Summary: Support `MediaControlActions::eStop` in `MediaControlKeysHandler` → Support `Stop` key event in `MediaControlKeysHandler`
|
|
Assignee | |
Comment 2•5 years ago
|
||
MediaControlKeysEvent should represent possible control key events, so adding a non-existing eNone in this class is not good. In addition, this property is only used in test currently, so we should modify test implementation and remove this property.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Extend MediaControlKeysEvent to support more buttons.
|
||
Updated•5 years ago
|
Attachment #9115567 -
Attachment is obsolete: true
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28330d9c4a35 part1 : remove 'MediaControlKeysEvent::eNone'. r=MeFisto94 https://hg.mozilla.org/integration/autoland/rev/0440279b1daf part2 : extend 'MediaControlKeysEvent'. r=MeFisto94
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/28330d9c4a35
https://hg.mozilla.org/mozilla-central/rev/0440279b1daf
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•