(Apologies in advance to my coworkers and their machines, for the cluttered-up temp dir, here.)

STR:

1. run ./mach raptor-test -t raptor-tp6-1-cold
2. while running, find the temp directory Raptor will use, and cd to it (for me, it's /var/folders/tn/jmgsfg315sd73yn_dnrf66c80000gn/T
3. in another shell, from that directory, run while true; clear; do ls -la | grep tmp; sleep 1; done and watch them populate in, and never get deleted

Actual Results:

"Leak" a bunch of created, used, and then never deleted temp folders.

cd /var/folders/tn/jmgsfg315sd73yn_dnrf66c80000gn/T; ls -la:

drwxr-xr-x 44 sdonner staff 1408 Dec 12 22:10 tmp2MjVtA
<snip>
....
drwxr-xr-x 44 sdonner staff 1408 Dec 12 22:09 tmpsb1Pzy

We leave 24 of them: https://gist.github.com/stephendonner/c34a835f0d68a6668ae82aaad7935d58

Expected Results:

No unnecessary temp directories lying around

From logs:

06:13:00 INFO - raptor-main Info: Making temp_download_dir from inside get_conditioned_profile /var/folders/tn/jmgsfg315sd73yn_dnrf66c80000gn/T/tmpK6yRTz
06:13:01 INFO - [2019-12-12T22:13:00.828636] Getting https://firefox-ci-tc.services.mozilla.com/api/index/v1/task/gecko.v2.mozilla-central.latest.firefox.condprof-macosx64/artifacts/public/condprof/profile-macosx64-settled-default.tgz
06:13:01 INFO - [2019-12-12T22:13:01.242088] Already Downloaded.
06:13:01 INFO - [2019-12-12T22:13:01.242483] Extracting the tarball content in /var/folders/tn/jmgsfg315sd73yn_dnrf66c80000gn/T/tmpK6yRTz
06:13:01 INFO - [2019-12-12T22:13:01.939412] Success, we have a profile to work with
06:13:01 INFO - raptor-main Info: self.conditioned_profile_dir is now set: /var/folders/tn/jmgsfg315sd73yn_dnrf66c80000gn/T/tmpK6yRTz
06:13:01 INFO - raptor-main Info: Merging profile: /Users/sdonner/mozilla-source/mozilla-unified/testing/profiles/base
06:13:01 INFO - raptor-main Info: Merging profile: /Users/sdonner/mozilla-source/mozilla-unified/testing/profiles/common
06:13:01 INFO - raptor-main Info: Merging profile: /Users/sdonner/mozilla-source/mozilla-unified/testing/profiles/perf
06:13:01 INFO - raptor-main Info: Merging profile: /Users/sdonner/mozilla-source/mozilla-unified/testing/profiles/raptor
06:13:01 INFO - raptor-main Info: Local browser profile: /var/folders/tn/jmgsfg315sd73yn_dnrf66c80000gn/T/tmpK6yRTz

BTW: it's great to see Tarek's caching code working, as seen in the log as "Already Downloaded.", from bug 1592696.

According to Tarek this will be taken care of in bug 1626726.