I don't think we should do this until we have top sites, showing the current list is not exactly the same, so please confirm with Verdi that it's ok to enable it with the old list.

I also think openViewOnFocus should only act when we'd run the empty search, that is when pageproxystate is valid, otherwise it would overlap in a confusing way with retained results, and would not act as a pure replacement for the dropdown.

(In reply to Marco Bonardo [:mak] from comment #1)

I don't think we should do this until we have top sites, showing the current list is not exactly the same, so please confirm with Verdi that it's ok to enable it with the old list.

Harry is looking into that, I can defer landing this until that's ready. Though I personally think it would be valuable to get the interaction model tested in Nightly sooner rather than later, and the dropmarker provides the same list anyway. If getting top sites into Nightly takes longer than expected, I may lobby for landing this sooner.

we should at least resolve the fact it may be activated when pageproxystate is invalid, that looks unexpected.

(In reply to Marco Bonardo [:mak] from comment #4)

we should at least resolve the fact it may be activated when pageproxystate is invalid, that looks unexpected.

I've commented in bug 1601052 comment 10. I think we're not on the same page here. It's something we should resolve one way or another, but I don't think it needs to block this. In fact, landing this in Nightly for dogfooding may help UX make a call on that issue.

Backed out changeset d5eba14afe3e (Bug 1603778) for causing xpcshell failures at browser/components/extensions/test/xpcshell/test_ext_urlbar.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=282475655&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=os%2Cx%2C10.14%2Cdebug%2Cxpcshell%2Ctests%2Ctest-macosx1014-64%2Fdebug-xpcshell-e10s-1%2Cx%28x1%29&revision=d5eba14afe3e89a941864d6f3878519f20cb96ec

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282475655&repo=autoland&lineNumber=4376

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=282475655&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=os%2Cx%2C10.14%2Cdebug%2Cxpcshell%2Ctests%2Ctest-macosx1014-64%2Fdebug-xpcshell-e10s-1%2Cx%28x1%29&revision=c8cdc2de9e4ed651c0c0ba833e778e36e01de9e5

[task 2019-12-24T11:26:51.764Z] 11:26:51     INFO -  TEST-PASS | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_urlbar.js | test_nonPrivateBrowsing - [test_nonPrivateBrowsing : 1412] 1 == 1
[task 2019-12-24T11:26:51.764Z] 11:26:51     INFO -  (xpcshell/head.js) | test run_next_test 22 pending (2)
[task 2019-12-24T11:26:51.764Z] 11:26:51     INFO -  (xpcshell/head.js) | test test_nonPrivateBrowsing finished (2)
[task 2019-12-24T11:26:51.764Z] 11:26:51     INFO -  xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_urlbar.js | Starting test_setOpenViewOnFocus
[task 2019-12-24T11:26:51.764Z] 11:26:51     INFO -  (xpcshell/head.js) | test test_setOpenViewOnFocus pending (2)
[task 2019-12-24T11:26:51.765Z] 11:26:51     INFO -  PID 6089 | [Child 6111, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/workspace/build/src/widget/cocoa/nsAppShell.mm, line 725
[task 2019-12-24T11:26:51.765Z] 11:26:51     INFO -  PID 6089 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2019-12-24T11:26:51.765Z] 11:26:51     INFO -  PID 6089 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2019-12-24T11:26:51.765Z] 11:26:51  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_urlbar.js | test_setOpenViewOnFocus - [test_setOpenViewOnFocus : 1421] Open-view-on-focus mode should be disabled by default - true == false
[task 2019-12-24T11:26:51.765Z] 11:26:51     INFO -  /Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/tests/browser/components/extensions/test/xpcshell/test_ext_urlbar.js:test_setOpenViewOnFocus:1421
[task 2019-12-24T11:26:51.765Z] 11:26:51     INFO -  /Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:run_next_test/_run_next_test/<:1567
[task 2019-12-24T11:26:51.765Z] 11:26:51     INFO -  /Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:_run_next_test:1567
[task 2019-12-24T11:26:51.765Z] 11:26:51     INFO -  /Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:run:735
[task 2019-12-24T11:26:51.765Z] 11:26:51     INFO -  /Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:_do_main:246
[task 2019-12-24T11:26:51.766Z] 11:26:51     INFO -  /Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:_execute_test:573
[task 2019-12-24T11:26:51.766Z] 11:26:51     INFO -  -e:null:1
[task 2019-12-24T11:26:51.766Z] 11:26:51     INFO -  exiting test
[task 2019-12-24T11:26:51.766Z] 11:26:51     INFO -  (xpcshell/head.js) | test run_next_test 22 finished (2)
[task 2019-12-24T11:26:51.766Z] 11:26:51     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2019-12-24T11:26:51.766Z] 11:26:51     INFO -  _abort_failed_test@/Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:791:20
[task 2019-12-24T11:26:51.766Z] 11:26:51     INFO -  do_report_result@/Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:892:5
[task 2019-12-24T11:26:51.767Z] 11:26:51     INFO -  Assert<@/Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:67:21
[task 2019-12-24T11:26:51.767Z] 11:26:51     INFO -  proto.report@resource://testing-common/Assert.jsm:233:10
[task 2019-12-24T11:26:51.767Z] 11:26:51     INFO -  equal@resource://testing-common/Assert.jsm:275:8
[task 2019-12-24T11:26:51.767Z] 11:26:51     INFO -  test_setOpenViewOnFocus@/Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/tests/browser/components/extensions/test/xpcshell/test_ext_urlbar.js:1421:10
[task 2019-12-24T11:26:51.767Z] 11:26:51     INFO -  run_next_test/_run_next_test/<@/Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:1567:22
[task 2019-12-24T11:26:51.767Z] 11:26:51     INFO -  _run_next_test@/Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:1567:38
[task 2019-12-24T11:26:51.767Z] 11:26:51     INFO -  run@/Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:735:9
[task 2019-12-24T11:26:51.768Z] 11:26:51     INFO -  _do_main@/Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:246:6
[task 2019-12-24T11:26:51.768Z] 11:26:51     INFO -  _execute_test@/Users/cltbld/tasks/task_1577172250/build/tests/xpcshell/head.js:573:5
[task 2019-12-24T11:26:51.768Z] 11:26:51     INFO -  @-e:1:1
[task 2019-12-24T11:26:51.768Z] 11:26:51     INFO -  exiting test

mak, if you get a chance, I would appreciate you addressing the xpcshell failure. Should be an easy fix. I don't have access to a PC right now.

Ah, sorry. I didn't see the backout and Dao's comments before pushing.

The failing test is a simple fix. I'll address it and re-push.

https://hg.mozilla.org/mozilla-central/rev/bdb51063d530