Closed Bug 1603831 Opened 5 years ago Closed 2 years ago

Sorting cookies in the storage inspector based on expiry time doesn't seem to work correctly

Categories

(DevTools :: Storage Inspector, defect, P3)

defect

Tracking

(firefox103 fixed)

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: miker)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [lang=js])

Attachments

(2 files, 3 obsolete files)

Attached image Screenshot (deleted) —

Please see the screenshot of me trying to sort the cookies from walmart.com in the storage inspector. The sorting does something but it's unclear what that is. I would have expected the sort to consider session cookies to expire first, and then sort the rest based on the expiry date and time.

We use a simple natural sort from devtools/shared/natural-sort.js.

We should probably special case "Session" here so that it appears at the top of the list.

Keywords: good-first-bug
Priority: -- → P2
Whiteboard: [lang=js]
Mentor: mratcliffe

Hi I am new to open source. Could you provide me some more information>

Flags: needinfo?(mratcliffe)
Assignee: nobody → sandhusimran3
Status: NEW → ASSIGNED
Flags: needinfo?(mratcliffe)

I can see that you are busy... would you like me to make the small changes I requested and land this for you?

Flags: needinfo?(sandhusimran3)
Attachment #9117415 - Attachment is obsolete: true
Attachment #9117246 - Attachment is obsolete: true

If sandhusimran3 is not editing the commit, can I change it for him?

Honza, can you help Eames?

Flags: needinfo?(odvarko)
Mentor: michael
Flags: needinfo?(odvarko)

@sandhusimran3: I am unassigning you from this bug since there was no activity for a long time - to make sure that anyone interested can pick this up and finish.

But please let me know if you still interested in this.

Thanks!

Honza

Assignee: sandhusimran3 → nobody
Status: ASSIGNED → NEW
Has STR: --- → yes

Greetings Mozilla Community! I'm new to Open Source and would love to contribute to this bug.

Is this still open?
I can finish this one using what @sandhusimran3 started.

(In reply to saiharsha_b from comment #11)

Greetings Mozilla Community! I'm new to Open Source and would love to contribute to this bug.

Ah, I missed this, sorry, are you still interested?

Honza

Flags: needinfo?(saibalsu)

Hi honza, I am very much interested in this bug ?
can u assign it to me?

Hi Honza,
I want to work on this issue .

Abhishek

Attached file Bug 1603831 - Added spaces at the start of comments. (obsolete) (deleted) —
Assignee: nobody → kamaraju428
Status: NEW → ASSIGNED
Flags: needinfo?(sandhusimran3)
Flags: needinfo?(saibalsu)
Keywords: good-first-bug
Attachment #9195792 - Attachment is obsolete: true

The bug assignee didn't login in Bugzilla in the last 7 months.
:Honza, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: kamaraju428 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(odvarko)

Abhishek, still interested in this bug?

Flags: needinfo?(odvarko) → needinfo?(mick.sharma02)

Redirect a needinfo that is pending on an inactive user to the triage owner.
:Honza, could you please find another way to get the information or close the bug as INCOMPLETE if it is not actionable?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mick.sharma02) → needinfo?(odvarko)

The sort logic still nees special case for "Session" cookies.
The patch seems to be close to what we need.

Honza

Flags: needinfo?(odvarko)

Multiple contributors have started on this bug and given up on it.

It has been 3 years so I'll quickly fix it.

Assignee: nobody → michael
Status: NEW → ASSIGNED
Attachment #9117419 - Attachment description: Bug 1603831 Sorting cookies in the storage inspector based on expiry time doesn't seem to work correctly - added a Special case for Session in natural-sort.js-version 3 → Bug 1603831 - Fix cookie sorting by date in storage panel r=#devtools-reviewers
Pushed by michael@ratcliffefamily.org: https://hg.mozilla.org/integration/autoland/rev/fe3be5c5efc0 Fix cookie sorting by date in storage panel r=devtools-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Regressions: 1789052
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: