Closed Bug 1603841 Opened 5 years ago Closed 4 years ago

Suppress event handling for BrowsingContextGroup while spinning event loop in window.open()

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1588259

People

(Reporter: kmag, Assigned: kmag)

References

Details

As a rule, we should always suppress event handling while spinning the event loop, and not doing so here allows for dangerous re-entrancy.

Event handling suppression wouldn't help with re-entrancy, since event handling suppression doesn't block all the JS to run.

(In reply to Olli Pettay [:smaug] from comment #1)

Event handling suppression wouldn't help with re-entrancy, since event handling suppression doesn't block all the JS to run.

I know, but it at least blocks some of it (in particular the JS that triggers the problem in bug 1588259). For the rest of it, I think we also need another check specific to window.open, as mentioned in bug 1588259 comment 4.

The priority flag is not set for this bug.
:kmag, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(kmaglione+bmo)
Priority: -- → P3

kmag, you said you have a patch in a different bug. I'd like to dupe this bug to that bug, but what is its bug #?

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(kmaglione+bmo)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.