Closed Bug 1604095 Opened 5 years ago Closed 5 years ago

Add support for `fix-stacks` and use it for DMD

Categories

(Toolkit :: Crash Reporting, task)

Product:
Toolkit
Component:
Crash Reporting
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(5 files)

Bug 1604095 - Add `fix_stacks.py`, which uses `fix-stacks`, and use it in DMD. r=gsvelto,glandium
(deleted), text/x-phabricator-request
Details
Bug 1604095 - Fix up `fix-stacks` toolchain on Mac. r=erahm
(deleted), text/x-phabricator-request
Details
Bug 1604095 - Install `fix-stacks` in `mach bootstrap`. r=glandium
(deleted), text/x-phabricator-request
Details
Bug 1604095 - Update the `fix-stacks` version. r=glandium
(deleted), text/x-phabricator-request
Details
Bug 1604095 - Build `fix-stacks` as 32-bit on Windows, cross-compiling from Linux. r=glandium
(deleted), text/x-phabricator-request
Details

fix-stacks is the new, fast, cross-platform stack fixer written in Rust.

Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED

Moving component to Toolkit > Crash Reporting, if this is not the correct component, please adjust it.

Component: General → Crash Reporting
Product: Core → Toolkit
Depends on: 1604964

It currently is missing some cross-compilation stuff and so actually builds a
Linux binary.

The commit also avoids the unintentional installation of the fix-stacks.d
file, by introducing the EXE variable.

Attachment #9116055 - Attachment description: Bug 1604095 - Add support for `fix-stacks` and use it in DMD. r=gsvelto → Bug 1604095 - Add `fix_stacks.py`, which uses `fix-stacks`, and use it in DMD. r=gsvelto,glandium
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42d63c42c6a2 Fix up `fix-stacks` toolchain on Mac. r=erahm

https://hg.mozilla.org/mozilla-central/rev/42d63c42c6a2

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

The new version has two improvements.

  • It has slightly changed output in some cases -- more similar to the existing
    stack fixers -- which avoids the need to change the DMD tests.
  • It fixes some erroneous double-JSON-escaping that caused excess backslashes
    in Windows paths.
Attachment #9129397 - Attachment description: Bug 1604095 - Install `fix-stacks` in `mach bootstrap`, and find it with configure. r=glandium → Bug 1604095 - Install `fix-stacks` in `mach bootstrap`. r=glandium
Blocks: 1619837
Blocks: 1619838
Keywords: leave-open
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4fa2ef53b3a8 Update the `fix-stacks` version. r=glandium https://hg.mozilla.org/integration/autoland/rev/7ffb4f86d024 Build `fix-stacks` as 32-bit on Windows, cross-compiling from Linux. r=glandium
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1083f8fd076a Install `fix-stacks` in `mach bootstrap`. r=glandium
Keywords: leave-open
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83f7d764a8ab Add `fix_stacks.py`, which uses `fix-stacks`, and use it in DMD. r=gsvelto
Blocks: 1619840
No longer blocks: 1619840
Blocks: 1621467
No longer blocks: 1596292, 1621467
Blocks: 1622701
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: