Closed
Bug 1604158
Opened 5 years ago
Closed 5 years ago
Auto-Detect submenu is shown when it shouldn't in hamburger menu and toolbar button
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
VERIFIED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | verified |
People
(Reporter: emk, Assigned: hsivonen)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Steps to reproduce:
- Make sure Nightly is the latest version.
- Make sure
intl.charset.detector.ng.enabledistrue(default). Ifintl.charset.detector.ng.enabledhas no value, your Nightly is probably old, back to 1. - Select the hamburger menu >
More>Text Encoding.
Actual result:
Auto-Detect submenu is shown which should not.
Expected result:
Auto-Detect submenu should be hidden.
|
Reporter | |
Comment 1•5 years ago
|
||
Apparently this change only affects menu bar > View > Text Encoding.
|
Assignee | |
Updated•5 years ago
|
Summary: Auto-Detect submenu is shown when it shouldn't → Auto-Detect submenu is shown when it shouldn't in hamburger menu and toolbar button
|
|
Reporter | |
Comment 2•5 years ago
|
||
This part should be hidden when intl.charset.detector.ng.enabled is true.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3af6ddc882e9d85eb48148d2847daf1af686457
(In reply to Masatoshi Kimura [:emk] from comment #2)
This part should be hidden when
intl.charset.detector.ng.enabledistrue.
Thanks!
|
||
Updated•5 years ago
|
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca0c893ca9f3
Hide the encoding detector submenu in hamburger/toolbar cases when chardetng is enabled. r=emk
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
|
||
Updated•5 years ago
|
Flags: qe-verify+
|
||
Comment 8•5 years ago
|
||
Verified using 73.0b3 (20200110003145) on Windows 10x64, macOS 10.15 and Ubuntu 16.04. While "intl.charset.detector.ng.enabled" is on true Auto-Detect submenu is not shown under hamburger menu > More > Text Encoding.
You need to log in
before you can comment on or make changes to this bug.
Description
•