Closed Bug 1604299 Opened 5 years ago Closed 5 years ago

Sort out existing references to XULDocument in our code

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: bzbarsky, Assigned: emmamalysz)

References

Details

Attachments

(1 file)

Bug 1604299, Remove remaining references to XULDocument
(deleted), text/x-phabricator-request
Details

https://searchfox.org/mozilla-central/search?q=XULDocument&case=true

  • The orderfile bits can just go away.
  • I'm not sure what devtools is doing and why; needs investigation.
  • The comments presumably no longer need to refer to XULDocument, since it's gone.
  • The canvas test may be able to be simplified, though maybe upstream?

(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #0)

  • I'm not sure what devtools is doing and why; needs investigation.

Julian just asked about the result in actors/inspector/inspector.js in https://bugzilla.mozilla.org/show_bug.cgi?id=1604126#c3 - I believe that one should go away.

The other DevTools check could probably just be changed to check system principal here https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/devtools/server/actors/inspector/utils.js#160-165. I'd have to double check but I think that condition was needed for something related to XBL (Bug 1187482) and I also don't remember why we went with "xul document" and not "chrome document" in the first place.

Depends on: 1604126
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1187482
Depends on: 1540278
Assignee: nobody → emalysz
Priority: -- → P2
Attachment #9117566 - Attachment description: Bug 1604299, remove XUL Document from our code → Bug 1604299, Remove remaining references to XULDocument
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b33ee7e44a88 Remove remaining references to XULDocument r=bgrins

https://hg.mozilla.org/mozilla-central/rev/b33ee7e44a88

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: