Closed Bug 1604485 Opened 5 years ago Closed 5 years ago

Add linter rule against loading client files in devtools/shared.

Categories

(DevTools :: General, task, P3)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
Firefox 73
Tracking Status
firefox73 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

Follow up to Bug 1591013.

Files in devtools/shared might be loaded on mobile Firefox where devtools/client is not available. So we should prevent from loading client modules in those files. A notable exception are fronts files. Those files are loaded only on the client and may load client modules.

We can simply exclude shared/fronts for now. This would have caught the mobile debugging regression in Bug 1602800, so I think it can be useful.

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/986025e43845 Add eslint rule against requiring client files from devtools/shared r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73

Thanks, we also got bitten by this recently!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: