Closed Bug 1604727 Opened 5 years ago Closed 5 years ago

Migrate .xul files in preferences to .xhtml

Categories

(Thunderbird :: Preferences, task)

Product:
Thunderbird
Component:
Preferences
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 73.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

1604727-migrate-prefs-xul-to-xhtml.patch
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review
No description provided.

I also renamed files that where referenced in the prefs to not touch the prefs files again.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9116647 - Flags: review?(mkmelin+mozilla)

(In reply to Richard Marti (:Paenglab) from comment #1)

I also renamed files that where referenced in the prefs to not touch the prefs files again.

I meant: I also renamed files in other directories that where referenced in the prefs to not touch the prefs files again.

Comment on attachment 9116647 [details] [diff] [review] 1604727-migrate-prefs-xul-to-xhtml.patch Review of attachment 9116647 [details] [diff] [review]: ----------------------------------------------------------------- Thx Richard! We might want to just wholesale replace the xul files across the code base though, since m-c already finished the migration, and there are some patches already being reviewed (bug 1601110) that would likely break us if we don't migrate. Do you want to take a look at that?
Attachment #9116647 - Flags: review?(mkmelin+mozilla) → review+

Or I can take take a run with it, and let you review ;)

When you have a script for it, much better when you do it. But attention: there are also "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" in the files that shouldn't be changed to xhtml. :-)

Keywords: checkin-needed-tb

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0b394917cc2e
Migrate .xul files in preferences to .xhtml. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 73.0
Pushed by richard.marti@gmail.com: https://hg.mozilla.org/comm-central/rev/94ea4b034b4d Follow-up: Fix missed rename in AboutRedirector.jsm and mailWindowOverlay.js. r=bustage-fix
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: