Closed
Bug 1604729
Opened 5 years ago
Closed 5 years ago
The device modal of the browser-embedded RDM should resize vertically too
Categories
(DevTools :: Responsive Design Mode, defect, P1)
DevTools
Responsive Design Mode
Tracking
(firefox74 verified)
VERIFIED
FIXED
Firefox 74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | verified |
People
(Reporter: pbro, Assigned: mtigley)
References
(Blocks 1 open bug)
Details
(Whiteboard: fission-rdm-mvp)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Steps:
- Make sure you have the new RDM turned on
devtools.responsive.browserUI.enabled - Open RDM on any page
- Open the device modal window
- Resize your browser window until the bottom of the device modal becomes hidden
Expected: like today with the old RDM, the device modal should resize both horizontally and vertically to adapt to the browser window size, so it always remains visible.
Actual: the bottom of the modal becomes hidden and you can't access certain elements.
|
||
Updated•5 years ago
|
Priority: -- → P3
Whiteboard: fission-rdm-reserve
|
Assignee | |
Comment 1•5 years ago
|
||
As per comment in: https://bugzilla.mozilla.org/show_bug.cgi?id=1604726#c3
We can fix this by adding height: 100% when the device modal is opened.
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mtigley
Priority: P3 → P1
|
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Whiteboard: fission-rdm-reserve → fission-rdm-mvp
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/178c4ce41ba6
Make device modal height take up 100% of the browser stack. r=bradwerth
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
|
||
Updated•5 years ago
|
Flags: qe-verify+
|
||
Comment 5•5 years ago
|
||
Confirmed issue with 73.0a1 (2019-12-15) on Windows 10 & 73.0 on Ubuntu 19.04.
Fix verified with 75.0a1 (2020-02-18) & 74.0b4 on Windows 10; 74.0b4 on macOS 10.15.3, Ubuntu 19.04.
You need to log in
before you can comment on or make changes to this bug.
Description
•