Open Bug 1604733 Opened 5 years ago Updated 2 years ago

Finish the conversion of the ThreadActor to protocol.js

Categories

(DevTools :: Framework, task, P3)

task

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

(Blocks 1 open bug)

Details

Follow up to Bug 1450944. Discussing with :ochameau, the Thread actor is not yet fully converted to protocoljs. Especially it overwrites the requestTypes generated via protocoljs at https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/devtools/server/actors/thread.js#2246-2256

Object.assign(ThreadActor.prototype.requestTypes, {
  attach: ThreadActor.prototype.onAttach,
  detach: ThreadActor.prototype.onDetach,
  reconfigure: ThreadActor.prototype.onReconfigure,
  resume: ThreadActor.prototype.onResume,
  interrupt: ThreadActor.prototype.onInterrupt,
  sources: ThreadActor.prototype.onSources,
  skipBreakpoints: ThreadActor.prototype.onSkipBreakpoints,
  pauseOnExceptions: ThreadActor.prototype.onPauseOnExceptions,
  dumpThread: ThreadActor.prototype.onDump,
});
Severity: normal normal → S3 S3
You need to log in before you can comment on or make changes to this bug.