Closed Bug 1604827 Opened 5 years ago Closed 5 years ago

Old content left behind on macOS with gfx.webrender.compositor

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla73
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- unaffected
firefox72 --- unaffected
firefox73 --- verified

People

(Reporter: jrmuizel, Assigned: gw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

This looks like a recent regression.

It looks like this bad content aligns with picture caching tiles.

confirmed seeing this on my personal macbook pro as well.

I suspect this might be because I have gfx.webrender.compositor set to true.

Summary: Old content left behind on macOS → Old content left behind on macOS with gfx.webrender.compositor

and the regression may have been cause by bug 1604383

Regressed by: 1604383
Has Regression Range: --- → yes
Priority: -- → P3

I saw something similar on Windows yesterday with compositor enabled. Probably best to disable compositor for now, until I have time to see what caused this. Since it happens on both compositor platforms, it's probably a bug in the WR code of the regressing bug, rather than the per-platform trait implementations.

Assignee: nobody → gwatson

Jeff, Alexis, could you confirm that you only see the bug if gfx.webrender.compositor is enabled? If that's the case, I don't need to look at this right away this morning.

Flags: needinfo?(jmuizelaar)
Flags: needinfo?(a.beingessner)

I haven't seen this since turning off gfx.webrender.compositor and saw it pretty often with it on. So I think we can assume that it's gfx.webrender.compositor only.

Flags: needinfo?(jmuizelaar)

Yep, same.

Flags: needinfo?(a.beingessner)

I need to do some more testing with this to verify it's a valid hack / workaround. If there are any other issues, I'll just back out the original patch, for now.

(In reply to Glenn Watson [:gw] from comment #10)

I need to do some more testing with this to verify it's a valid hack / workaround. If there are any other issues, I'll just back out the original patch, for now.

It seems to work OK for me, and I think this patch should fix all cases of this.

The new build seems to work for me too.

Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2dd771769da7 Workaround for stale tile content in native compositor mode. r=sotaro

Turns out I didn't turn on gfx.webrender.compositor in the new build :)

I'm able to reliably reproduce the problem by scrolling down to the sample image on https://docs.rs/raqote/0.7.6/raqote/. I can not reproduce the problem in the new build with gfx.webrender.compositor turned on.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Flags: qe-verify+

I've reproduce this issue with Fx 72.0a1(2019-12-18) on macOS 10.15 (MacBook Pro).
The issue is verified fixed with Fx 74.0a1(2020-02-01) and Fx 73.0b12 on macOS 10.15 and Windows 10.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: