Affected versions

• 72.0b8
• 71.0

Affected platforms

• Ubuntu 18.04x64

Steps to reproduce

1. Launch FF with a fresh profile.
2. Got to about:preferences#general
3. Go to Language&Appearence section, Colors
4. Invert the Text&Background colors (Black text to White, and White background to black)
5. Select "Always" in the override the colors drop down.
6. Press ok.
7. Open a new tab.

Expected result

• The page is properly rendered and the icons of the visited and bookmarked websites are properly displayed.

Actual result

• The contents of the visited and bookmarked pages have no icons and the page is not rendered correctly.

Regression range

• will return with regression ASAP.

Additional notes

• As long as the Always option in the "override the colors" drop down,remains active, the page will not be rendered correctly and the website icons will not be displayed even after reverting the colors to default.
  *Does not occur in latest FF Nightly

Screencast to issues

• https://drive.google.com/open?id=1Qzu7_Vk-H-JOfe6pzdUez6lBkvgpDC6-
• https://drive.google.com/open?id=1PA2VNN5fkUNwW1VAeMY6BOwr-qptJE4S

Hey Morgan, do you have a sense of how important this issue is, accessibility-wise?

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #1)

Hey Morgan, do you have a sense of how important this issue is, accessibility-wise?

Hello! I'd access-p1 this by: https://docs.google.com/document/d/1UOI65Ghjj615NOvdOTWtCW790lgikDiUsE8Ss7pkdo0/edit

Old high contrast mode prevented images from rendering; looks like that's what's happening in the screenshots. Might be worth checking out if this was changed by 1594099 landing (this allows images)

Thanks, Morgan! Going to mark P3 for now. ni?ing vlucaci for that regression range too.

I think this is a dupe of bug 1445266, but using the prefs instead of high contrast mode (which we don't support auto-detecting on Linux, cf bug 239914). Pinging Mardak to check. Either way, I don't think this is fixable in preferences.

It'd be useful to confirm if this was indeed fixed on nightly by bug 1594099 - per that bug, I think that's being held on Nightly so a fix on release isn't forthcoming just yet?

This is what I'm seeing when I follow the STR after landing backplate work in Nightly.
Backplate stuff is going to wait one more cycle in beta before being uplifted to release (so released in 73, I think?)

I have managed to find a regression for this issue here is the pushlog https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=80ff3f300e05f38f96c385b03d1973a966a2bd35&tochange=7d15bc419c6cd7e9f3b4d41370c3b0e5990c8d1b. I want to mention that the pushlog provided is from when the new tab page was changed to the new design, also this behaviour reproduces as low as Fx 33.0a1.

I have performed a regression of the fix using mozregression and these are my results:

2020-01-10T16:41:01: INFO : Narrowed inbound regression window from [86961574, f44e6327] (3 builds) to [86961574, 6baef669] (2 builds) (~1 steps left)
2020-01-10T16:41:01: DEBUG : Starting merge handling...
2020-01-10T16:41:01: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=6baef669e147828062e93a6e7edec259853e7304&full=1
2020-01-10T16:41:02: DEBUG : Found commit message: Bug 1539212: Add readability backplate for all elements containing text when HCM or a11y theme is active. r=dholbert,mattwoodrow,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42979
2020-01-10T16:41:02: DEBUG : Did not find a branch, checking all integration branches
2020-01-10T16:41:02: INFO : The bisection is done.
2020-01-10T16:41:02: INFO : Stopped

Conclusion: The fix appears to be pushed for bug 1539212.

(In reply to Bodea Daniel [:danibodea] from comment #9)

I have performed a regression of the fix using mozregression and these are my results:

2020-01-10T16:41:01: INFO : Narrowed inbound regression window from [86961574, f44e6327] (3 builds) to [86961574, 6baef669] (2 builds) (~1 steps left)
2020-01-10T16:41:01: DEBUG : Starting merge handling...
2020-01-10T16:41:01: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=6baef669e147828062e93a6e7edec259853e7304&full=1
2020-01-10T16:41:02: DEBUG : Found commit message: Bug 1539212: Add readability backplate for all elements containing text when HCM or a11y theme is active. r=dholbert,mattwoodrow,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42979
2020-01-10T16:41:02: DEBUG : Did not find a branch, checking all integration branches
2020-01-10T16:41:02: INFO : The bisection is done.
2020-01-10T16:41:02: INFO : Stopped

Conclusion: The fix appears to be pushed for bug 1539212.

Sorry, I'm confused - are you saying bug 1539212 fixed this? Because you then marked it as a regressor, ie saying that bug caused this one. Those are opposite things...

Yes, that is what fixed the issue. Do you still need me to find out when it was introduced?

No, I think it's not a recent regression and there's a fix on nightly (albeit behind a pref that's not riding the trains at the moment, I think?) so that's fine for now.

(In reply to :Gijs (he/him) from comment #12)

No, I think it's not a recent regression and there's a fix on nightly (albeit behind a pref that's not riding the trains at the moment, I think?) so that's fine for now.

It [backplate]'ll be fully released in 73; if there's a way to note that this bug will be fixed then, let me know and I'll mark it :)

(In reply to Morgan Reschenberg [:morgan] from comment #13)

(In reply to :Gijs (he/him) from comment #12)

No, I think it's not a recent regression and there's a fix on nightly (albeit behind a pref that's not riding the trains at the moment, I think?) so that's fine for now.

It [backplate]'ll be fully released in 73; if there's a way to note that this bug will be fixed then, let me know and I'll mark it :)

https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#801 is still marked EARLY_BETA_OR_EARLIER, as is the beta copy of that file. Is there a separate bug on file for enabling it on late beta / release ? Or something else tracking that? Because otherwise, I don't think this is shipping in terms of being user-visible...

(In reply to :Gijs (he/him) from comment #14)

(In reply to Morgan Reschenberg [:morgan] from comment #13)

(In reply to :Gijs (he/him) from comment #12)

No, I think it's not a recent regression and there's a fix on nightly (albeit behind a pref that's not riding the trains at the moment, I think?) so that's fine for now.

It [backplate]'ll be fully released in 73; if there's a way to note that this bug will be fixed then, let me know and I'll mark it :)

https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#801 is still marked EARLY_BETA_OR_EARLIER, as is the beta copy of that file. Is there a separate bug on file for enabling it on late beta / release ? Or something else tracking that? Because otherwise, I don't think this is shipping in terms of being user-visible...

Uplift and pref-flip are bug 1608889 ! I'm working on it; had a misunderstanding on the release date but should uplift the pref change today.