Open
Bug 1604947
Opened 5 years ago
Updated 4 years ago
Sometimes UI prefs are reset; TUI cookie should be replaced with local storage
Categories
(bugzilla.mozilla.org :: User Interface, defect)
bugzilla.mozilla.org
User Interface
Tracking
()
NEW
People
(Reporter: kohei, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
Currently TUI.js uses a cookie to save a couple of UI preferences, including:
- Show/Hide Advanced Fields on Enter Bug page
- Toggle sections on Advanced Search page
And sometimes people say these settings have been reset. Though we don’t know exactly what’s happening here, the problem can be probably avoided by using local storage instead. Ideally we should store all those prefs remotely for sync between multiple devices, but the bug can be fixed easily.
|
Reporter | |
Comment 1•5 years ago
|
||
We should ditch the YUI stuff. Also, the toggle function should be using WAI-ARIA for a better a11y.
Blocks: 1493992
|
|
Reporter | |
Comment 3•5 years ago
|
||
I took a look at this briefly. It’s apparently not a cookie issue, because your login will never be lost, but a race condition in the code. To reduce bandwidth, UI cookies should be replaced with local storage anyway though. Will send a PR tonight or tomorrow when I have time.
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 4•5 years ago
|
||
|
|
Reporter | |
Updated•4 years ago
|
Assignee: kohei.yoshino → nobody
Status: ASSIGNED → NEW
You need to log in
before you can comment on or make changes to this bug.
Description
•