Page.getFrameTree has to return details for all frames in the current tab
Categories
(Remote Protocol :: CDP, enhancement, P1)
Tracking
(firefox77 fixed)
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Depends on 1 open bug, Blocks 5 open bugs)
Details
(Whiteboard: [puppeteer-beta-mvp])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Right now we simply return a list of frames that gets constructed each time when Page.getFrameTree gets called. This is totally inefficient, and we should make it dynamic. Means it might have to handle the Page.frameAttached (bug 1599413) and Page.frameDetached (bug 1599773) events.
As Andreas mentioned to me maybe the browsing context class already has such a feature which we would only have to iterate over. It's worth a check.
But this is all Fission related.
|
Assignee | |
Comment 1•5 years ago
|
||
Note that the current implementation also lives on the content side of Page.jsm. It would have to be moved to domains/parent/Page.jsm.
|
|
Assignee | |
Comment 2•5 years ago
|
||
To properly implement Page.frameAttached and Page.frameDetached I need an implementation of a frame tree class. As such we need this bug in our MVP, and bug 1601421 is moved to the backlog.
|
|
Assignee | |
Comment 3•5 years ago
|
||
The dynamic handling of frames is actually implemented in Puppeteer, and that's not needed here. What we have to do is to return all the frames for the current tab, including nested and x-origin ones. This can easily be done now that we have the browsing context tree.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Description
•