Whitelisting the meet.jit.si domain doesn't block the mDNS
Categories
(Core :: WebRTC: Networking, defect, P2)
Tracking
()
People
(Reporter: asoncutean, Assigned: dminor)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
Bug 1605419 - Use GetDocumentURI instead of GetDocBaseURI for hostname obfuscation whitelist; r=jib!
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
[Affected versions]:
- 72.0b9
[Affected platforms]:
- all platforms
[Steps to reproduce]:
- Add meet.jit.si inside media.peerconnection.ice.obfuscate_host_addresses.whitelist pref
- Create a room and initiate/join a call on two ends
- Go to about:webrtc page
[Expected result]:
- IP addresses are not hidden
[Actual result]:
- mDNS addresses are generated
[Regression range]:
- I will come back with more info on Monday
[Additional notes]:
- File.pizza and talky.io worked just fine
- Different variants around this domain didn't work either
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
The problem is that the jit.si site has:
<base href="https://web-cdn.jitsi.net/meetjitsi_3773.460/">
in its html, which is causing the hostname to show up to the code as web-cdn.jitsi.net. If I whitelist that url, things work as expected. I'll do some more checking to see if we should be handling things differently.
Assignee | ||
Comment 2•5 years ago
|
||
We don't need a regression window for this, this was not a case that was considered when the whitelist was implemented, and may end up being a site issue.
Assignee | ||
Comment 3•5 years ago
|
||
Sure enough I was using GetDocBaseURI() rather than GetDocumentURI(). I don't think there is any reason to not use GetDocumentURI() here.
Assignee | ||
Comment 4•5 years ago
|
||
Comment 6•5 years ago
|
||
bugherder |
Assignee | ||
Comment 7•5 years ago
|
||
Comment on attachment 9117355 [details]
Bug 1605419 - Use GetDocumentURI instead of GetDocBaseURI for hostname obfuscation whitelist; r=jib!
Beta/Release Uplift Approval Request
- User impact if declined: Limits the ability to whitelist disabling hostname obfuscation for some domains.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very low, we're just switching the api call used to get the document uri, which should not make a difference for the majority of sites.
- String changes made/needed: None
Comment 8•5 years ago
|
||
Comment on attachment 9117355 [details]
Bug 1605419 - Use GetDocumentURI instead of GetDocBaseURI for hostname obfuscation whitelist; r=jib!
approved for 72.0b11
Comment 9•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Reporter | ||
Comment 10•5 years ago
|
||
This issue is verified fixed with Fx 72.0b11 and Fx 73.0a1 (2019-12-26) on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64.
Description
•