Closed
Bug 1605658
Opened 5 years ago
Closed 5 years ago
ValueToSource should handle JSFunctions explicitly as a fallback
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Currently js::ValueToSource works by calling toSource on objects, and falling back to ObjectToSource if that property is not callable. I am adding an explicit case for JSFunction.
Otherwise removing toSource degrades existing error messages involving functions. In the future we might want to explicitly handle some more object types.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/79d517bdae7a
ValueToSource should handle JSFunctions explicitly as a fallback. r=arai
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•