Decrease UDP socket read timeout in mDNS service
Categories
(Core :: WebRTC: Networking, defect, P2)
Tracking
()
People
(Reporter: dminor, Assigned: dminor)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In Bug 1601992 we're seeing occasional shutdown hangs with a stack trace like:
0 ntdll.dll NtWaitForSingleObject
1 mswsock.dll SockWaitForSingleObject
2 mswsock.dll guard_check_icall_nop
3 ws2_32.dll WSARecvFrom
4 wsock32.dll recvfrom
5 xul.dll static void mdns_service::{{impl}}::start::{{closure}}(struct mdns_service::{{impl}}::start::closure-0) media/mtransport/mdns_service/src/lib.rs:382
The current read timeout of 10ms was chosen arbitrarily. I'd like to try a smaller timeout to see if it helps with the shutdown hangs we're seeing.
|
Assignee | |
Comment 1•5 years ago
|
||
The original values of 10ms were chosen arbitrarily. Decreasing the values may
help prevent shutdown hanges like those seen in Bug 1601992.
|
||
Updated•5 years ago
|
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec9b07bbdf77 Decrease UDP socket timeouts in mDNS service; r=mjf
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
||
Comment 4•5 years ago
|
||
I'm having a difficult time ascertaining what affect this patch had. Have you seen a noticeable change in any shutdown hang bugs you're looking at, Dan?
|
|
Assignee | |
Comment 5•5 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
I'm having a difficult time ascertaining what affect this patch had. Have you seen a noticeable change in any shutdown hang bugs you're looking at, Dan?
The shutdown hangs were pretty uncommon and only showed up in beta, but the mDNS stuff is currently disabled there, so we won't see the effect (if any) of this patch until Firefox 74 hits beta.
|
|
||
Updated•5 years ago
|
Description
•