Closed
Bug 1606608
Opened 5 years ago
Closed 5 years ago
mTotalPixelCount gets out of sync when surfaces are deleted
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox72 | --- | unaffected |
| firefox73 | --- | wontfix |
| firefox74 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
There was a small bug in the patch for bug 1604383 which causes the "WR OS Compositor frame" profiler markers to report unrealistic values.
|
Assignee | |
Comment 1•5 years ago
|
||
This fixes RenderCompositorOGL::DestroySurface to update mTotalPixelCount as needed when there are still tiles in the surface that's getting removed.
I'm also adding a few asserts and performing some minor cleanup.
|
||
Updated•5 years ago
|
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/602c2c720a7f
Fix mTotalPixelCount bug and do some cleanup. r=gw
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
|
||
Comment 4•5 years ago
|
||
Not sure if this needs uplift to Beta or not, but feel free to nominate it if so.
status-firefox72:
--- → unaffected
status-firefox73:
--- → affected
status-firefox-esr68:
--- → unaffected
Flags: needinfo?(mstange)
|
|
Assignee | |
Comment 5•5 years ago
|
||
Doesn't need to be uplifted, this affects a code path that's still off by default, and not in a user-facing way.
Flags: needinfo?(mstange)
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•