Determine whether we need FakeString or equivalent instead of nsAutoCString for UTF8String
Categories
(Core :: DOM: Bindings (WebIDL), defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In bug 1449861 I used plain nsAutoCString because the callees were using NS_ConvertUTF16ToUTF8, which is already an nsAutoCString subclass. So we're not paying more for that than we used to.
However, Boris points that we created FakeString because nsAutoString was a bit too slow for bindings. We should profile and determine whether we need to make FakeString generic over the char type.
Or we should probably just do that, as it's not much code I suspect.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
|
||
Comment 3•5 years ago
|
||
Backed out changeset 05d084629569 (bug 1606958) for causing Valgrind bustages.
Backout revision https://hg.mozilla.org/integration/autoland/rev/585ff82b95f7d01da6c282ba484923bc0313af83
Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=283736375&repo=autoland
Emilio can you please take a look?
|
|
Assignee | |
Comment 4•5 years ago
|
||
It was a legit failure, revised the patch.
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•