Closed
Bug 1607172
Opened 5 years ago
Closed 5 years ago
Use ESLint's new ignorePatterns configuration option to ignore paths from ThirdPartyPaths.txt
Categories
(Developer Infrastructure :: Lint and Formatting, task, P2)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox74 fixed)
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(4 files)
In ESLint 6.7.0, ESLint added an ignorePatterns configuration option.
This allows us to set ignorePatterns in the top-level .eslintrc.js. As this is a node file, we can read the list from ThirdPartyPaths.txt to get a list of the third-party directories to ignore.
We can then simplify .eslintignore down to just the directories we don't want to lint (node_modules, crashtests etc), and the unlintables (preprocessed files etc).
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D59691
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D59692
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D59693
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20aa5934c785
Update ESLint to the latest version and use ignorePatterns to ignore paths listed in ThirdPartyPaths.txt. r=mossop
https://hg.mozilla.org/integration/autoland/rev/99ce7a56080e
Move devtools third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for devtools. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/93023b1b6153
Automatically fix ESLint issues in non-third party dom/media/webvtt/ files. r=jya
https://hg.mozilla.org/integration/autoland/rev/d69d6dfdccad
Move dom third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for dom. r=jya
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e3a24d5378f
Backed out 9 changesets (bug 1607172, bug 1609998, bug 1608799) for causing xpcshell failures in test_parser.js
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1828d488ee8
Update ESLint to the latest version and use ignorePatterns to ignore paths listed in ThirdPartyPaths.txt. r=mossop
https://hg.mozilla.org/integration/autoland/rev/b595c6a105ab
Move devtools third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for devtools. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/0c14f3e3dab1
Automatically fix ESLint issues in non-third party dom/media/webvtt/ files. r=jya
https://hg.mozilla.org/integration/autoland/rev/62a823fb3aac
Move dom third-party entries across to ThirdPartyPaths.txt, and clean up .eslintignore for dom. r=jya
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f1828d488ee8
https://hg.mozilla.org/mozilla-central/rev/b595c6a105ab
https://hg.mozilla.org/mozilla-central/rev/0c14f3e3dab1
https://hg.mozilla.org/mozilla-central/rev/62a823fb3aac
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
|
|
Assignee | |
Updated•5 years ago
|
Iteration: --- → 74.2 - Jan 20 - Feb 09
|
||
Updated•4 years ago
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•