Closed Bug 1607613 Opened 5 years ago Closed 4 years ago

Tools - Account Settings - Junk Settings - Select and Toggle Broken

Categories

(Thunderbird :: Account Manager, defect)

defect
Not set
normal

Tracking

(thunderbird_esr78 fixed, thunderbird79 fixed)

RESOLVED FIXED
Thunderbird 80.0
Tracking Status
thunderbird_esr78 --- fixed
thunderbird79 --- fixed

People

(Reporter: r, Assigned: darktrojan)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

Under Tools -> Account Settings select a server.
Click on Junk Settings.
In the Do not automatically mark mail as junk if the sender is list click on a mailing list.
Note the space-bar toggles the check-mark.
Use the cursor keys to move the selection bar and note the highlight moves.
Press the space-bar and note the PREVIOUSLY-SELECTED item is toggled (not the current selection.)

Actual results:

Changing the selection by clicking moves the highlight and the space-bar toggles the highlighted item.
Navigating with the cursor keys changed the highlight but the space-bar toggles the previous selection.

Expected results:

Changing the selection with the cursor keys or clicking the mouse should be equivalent.

Marco, can you reproduce this on windows?

Flags: needinfo?(marcoagpinto)
Component: Untriaged → Account Manager

@Wayne,

Yes, I can confirm the bug.

I moved to the line above using the cursor key and when I pressed SPACE it toggled the line below check box.

Flags: needinfo?(marcoagpinto)

With TAB it moves the focus (see the dotted focus ring) but not the selection background and then it works. Maybe aceman or Geoff can help here.

Thoughts?

Flags: needinfo?(geoff)

The checkboxes are stealing focus from the richlistbox, but it's still changing the selection because the keyboard events are coming from inside it. So I'm preventing the checkboxes from having focus, and simulating the keyboard space/enter action.

Assignee: nobody → geoff
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(geoff)
Attachment #9163732 - Flags: review?(khushil324)
Attachment #9163732 - Flags: approval-comm-beta?
Comment on attachment 9163732 [details] [diff] [review] 1607613-junk-settings-list-1.diff Review of attachment 9163732 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil
Attachment #9163732 - Flags: review?(khushil324) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3a7bdd6a51af
Fix keyboard navigation errors in junk settings address book list. r=khushil

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 80.0
Comment on attachment 9163732 [details] [diff] [review] 1607613-junk-settings-list-1.diff Approved for beta
Attachment #9163732 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 9163732 [details] [diff] [review] 1607613-junk-settings-list-1.diff Very low risk.
Attachment #9163732 - Flags: approval-comm-esr78?
Comment on attachment 9163732 [details] [diff] [review] 1607613-junk-settings-list-1.diff Approved for esr78
Attachment #9163732 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: