Closed
Bug 1607783
Opened 5 years ago
Closed 5 years ago
Check precondition `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected`
Categories
(Core :: DOM: Selection, enhancement)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Otherwise it's hard to reason about the method and its implementation, moreover it could return wrong results.
|
Assignee | |
Updated•5 years ago
|
Summary: Assert `aStartOffset <= aEndOffset` for `nsRange::IsNodeSelected` → Assert `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected`
|
|
Assignee | |
Updated•5 years ago
|
Summary: Assert `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected` → Check invariant `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected`
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Summary: Check invariant `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected` → Check precondition `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected`
|
||
Updated•5 years ago
|
Attachment #9119667 -
Attachment description: Bug 1607783: check invariant in `nsRange::IsNodeSelected`. r=smaug → Bug 1607783: check precondition in `nsRange::IsNodeSelected`. r=smaug
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/221163f3f179
check precondition in `nsRange::IsNodeSelected`. r=smaug
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•