Closed Bug 1607818 Opened 5 years ago Closed 5 years ago

GeckoView socket process crashes on startup

Categories

(GeckoView :: Sandboxing, defect, P1)

Unspecified
All
defect

Tracking

(firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: bdahl, Assigned: bdahl)

References

Details

Attachments

(1 file)

Running a mochitest locally fails. The socket process crashes with the following warning

WARNING: NS_ENSURE_TRUE(appShell) failed

The reason the appshell is blocked is because we don't specify which process that appshell can be run in for android. This make is default to any process, but for sockets you you have to explicitly enable it e.g. ProcessSelector.ALLOW_IN_GPU_RDD_VR_AND_SOCKET_PROCESS

Hey Bryon,

I can fix the socket process on android with above fix. However, I'm wondering if we should just disable for now? Also, is the socket process being actively worked on?

Flags: needinfo?(docfaraday)

Socket process is being used/worked on, yes. We hope to make it the default mode of operation, so let's try to make it work here.

In your test, is e10s being used?

Flags: needinfo?(docfaraday)
Priority: -- → P1

In local Android builds the socket process is enabled. However, AppShell
creation is not allowed which causes the process to crash. This syncs the
flags with desktop.

(In reply to Byron Campen [:bwc] from comment #2)

In your test, is e10s being used?

Yeah, mochitests on android have e10s enabled.

One thing that's problematic here though, is local mochitest and mochitest run on the try server have different settings for network.process.enabled. I don't quite understand the discrepancy (maybe this or this). I think we should work to unify this though, so we don't run into the situation again where things fail locally, but not on try.

Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a014eddc5aaa Allow AppShell creation in socket process on Android. r=kmag
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Moving socket process bugs to the new GeckoView::Sandboxing component.

Component: General → Sandboxing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: