Closed Bug 1608025 Opened 5 years ago Closed 5 years ago

QM: Clean up storage upgrade tests

Categories

(Core :: Storage: Quota Manager, task, P2)

Product:
Core
Component:
Storage: Quota Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: janv, Assigned: janv)

References

(Blocks 1 open bug)

Details

Attachments

(11 files)

Bug 1608025 - Move storage upgrade related tests to a separate directory; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Legacy upgrade methods should only be called when storage.sqlite doesn't exist; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Clean up the test for the upgrade from flat origin directories; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Clean up the test for the upgrade from indexedDB/ directory; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Clean up the test for the upgrade from storage/persistent/ directory; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Add tests for the removal of old indexedDB/ and storage/persistent/ directories; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Clean up the test for the upgrade from storage version 0.0; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Clean up the tests for the upgrade from storage version 1.0; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Clean up the test for the upgrade from storage version 2.0; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Clean up the test for the upgrade from storage version 2.1; r=asuth
(deleted), text/x-phabricator-request
Details
Bug 1608025 - Add a test for the upgrade from storage version 2.2; r=asuth
(deleted), text/x-phabricator-request
Details

Storage upgrade tests (and packaged profiles) now live in dom/quota/test/unit. The naming is not consistent and it's hard to match a test to a C++ method that it verifies. The goal of this bug is to clean up this stuff before we add another (really) major upgrade to QM storage v4.

I have like 10 patches for this, finishing work on the last one.

Blocks: 1608759
Depends on: 1606318
Summary: QM: Cleanup storage upgrade tests → QM: Clean up storage upgrade tests
Attachment #9120400 - Attachment description: Bug 1608025 - Clean up the test for the upgrade from flat origin directory structure; r=asuth → Bug 1608025 - Clean up the test for the upgrade from flat origin directories; r=asuth

An additional test is added for the complete upgrade from flat origin directories.

This patch also refactors relevant upgrade methods to do the removal directly.

This patch also fixes the code to correctly handle the removal of appId origin
attribute.

Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bfe435dd9518 Move storage upgrade related tests to a separate directory; r=asuth https://hg.mozilla.org/integration/autoland/rev/b42b9eb33eaf Legacy upgrade methods should only be called when storage.sqlite doesn't exist; r=asuth https://hg.mozilla.org/integration/autoland/rev/9e33dfa84210 Clean up the test for the upgrade from flat origin directories; r=asuth https://hg.mozilla.org/integration/autoland/rev/397709016962 Clean up the test for the upgrade from indexedDB/ directory; r=asuth https://hg.mozilla.org/integration/autoland/rev/e6a6d0ab1011 Clean up the test for the upgrade from storage/persistent/ directory; r=asuth https://hg.mozilla.org/integration/autoland/rev/a5fff698c9bc Add tests for the removal of old indexedDB/ and storage/persistent/ directories; r=asuth https://hg.mozilla.org/integration/autoland/rev/08bec548525f Clean up the test for the upgrade from storage version 0.0; r=asuth https://hg.mozilla.org/integration/autoland/rev/968faf5e2e78 Clean up the tests for the upgrade from storage version 1.0; r=asuth https://hg.mozilla.org/integration/autoland/rev/40063da9c025 Clean up the test for the upgrade from storage version 2.0; r=asuth https://hg.mozilla.org/integration/autoland/rev/cef274a06b24 Clean up the test for the upgrade from storage version 2.1; r=asuth https://hg.mozilla.org/integration/autoland/rev/01d1158f3c71 Add a test for the upgrade from storage version 2.2; r=asuth
No longer blocks: 1593365
Blocks: 1619891
Blocks: 1620277
No longer blocks: 1608759
No longer blocks: 1619891
No longer depends on: 1606318
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: