Closed
Bug 1608071
Opened 5 years ago
Closed 5 years ago
Rename common ancestor to closest common inclusive ancestor around `nsRange`
Categories
(Core :: DOM: Selection, enhancement)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
It's more precise and enables one to reason more clearly about related
code.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D59318
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
The old name was misleading.
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D59336
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45b85dcadda9
part 1) Rename common ancestor to closest common inclusive ancestor around `nsRange`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e73fe8488d7c
part 2) Rename `nsContentUtils::GetCommonAncestor` and related methods. r=smaug
https://hg.mozilla.org/integration/autoland/rev/76ff9dd86471
part 3) Rename `nsSlots::mCommonAncestorRanges` to `nsSlots::mClosestCommonInclusiveAncestorRanges`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/29c840428360
part 4) Rename `GetNextRangeCommonAncestor`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/ab4bc0bbd2c5
part 5) Remove superfluous code in `nsRange::IsNodeSelected`. r=smaug
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/45b85dcadda9
https://hg.mozilla.org/mozilla-central/rev/e73fe8488d7c
https://hg.mozilla.org/mozilla-central/rev/76ff9dd86471
https://hg.mozilla.org/mozilla-central/rev/29c840428360
https://hg.mozilla.org/mozilla-central/rev/ab4bc0bbd2c5
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•