Closed Bug 1608124 Opened 5 years ago Closed 5 years ago

[shared font list] macOS "hidden" system font families should not be recognized in the CSS `font-family` list

Categories

(Core :: Layout: Text and Fonts, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(1 file)

Testcase:

data:text/html,<div style="font:36px '.SF NS Text', Times">Hello World

renders (correctly) in Times Roman without the shared font list enabled, but in .SF NS Text (which should not be exposed by name to the user) with the shared list enabled.

Inspecting the shared font list code shows that it correctly sets a "hidden family" flag on these fonts when building the list on macOS.... but subsequently fails to pay any attention to that flag when it's time to look up font names.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aea131093cd1 Skip hidden macOS font families in FontList::FindFamily, except when resolving system fonts. r=jwatt

Ah, we can't use the reftest manifest to tweak a mirror: once pref. (And changing the pref to mirror: always won't help, as it is only checked at startup.) So we should just drop the pref annotation from this testcase and not worry about having it run for now. When we actually flip the default value, it'll be here to let us know if things are broken.

Flags: needinfo?(jfkthame)
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ccb7b8c14ea Skip hidden macOS font families in FontList::FindFamily, except when resolving system fonts. r=jwatt
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: