Closed Bug 1608165 Opened 5 years ago Closed 5 years ago

[MSU Capstone] Port toolkit/chrome/mozapps/profile/profileSelection.dtd to Fluent

Categories

(Toolkit :: Startup and Profile System, task, P3)

task

Tracking

()

VERIFIED FIXED
mozilla76
Tracking Status
firefox76 --- verified

People

(Reporter: mconley, Assigned: salniker)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Summary: Port toolkit/chrome/mozapps/profile/profileSelection.dtd to Fluent → [MSU Capstone] Port toolkit/chrome/mozapps/profile/profileSelection.dtd to Fluent

Hey gandalf, Mossop mentioned that this might actually be kind of tricky because the last time he looked, Fluent isn't available before profile-before-change. Is that still true?

Flags: needinfo?(gandalf)

Hey gandalf, Mossop mentioned that this might actually be kind of tricky because the last time he looked, Fluent isn't available before profile-before-change. Is that still true?

How is it different from DTD? The API should be available but langpack selection may not be done at this point, which should match the DTD behavior. Am I missing something?

Flags: needinfo?(gandalf) → needinfo?(dtownsend)

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #2)

Hey gandalf, Mossop mentioned that this might actually be kind of tricky because the last time he looked, Fluent isn't available before profile-before-change. Is that still true?

How is it different from DTD? The API should be available but langpack selection may not be done at this point, which should match the DTD behavior. Am I missing something?

Last I checked locale registration hadn't happened before the profile was brought up, so even the built-in locale was not available.

Flags: needinfo?(dtownsend)

I tested it by adding a <link rel="localization"/> to preferences.ftl and replacing one description with a data-l10n-id backed and it worked well, so I'd expect it to work on par with DTD!

Excellent, sounds like this bug is unblocked then. Thanks, gandalf!

Assignee: nobody → salniker
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/44462bd32150 port profileSelection DTD to fluent r=Gijs,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76

Verified fixed as part of PI 551; tested with Nightly 77 across platforms (Windows 10, macOS 10.15 and Ubuntu 18.04).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: