Closed
Bug 1608272
Opened 5 years ago
Closed 4 years ago
Ban the use of passing this as the second argument to ChromeUtils.import
Categories
(Firefox :: General, task, P5)
Firefox
General
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: mossop, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
Bug 1608272 - Extend an ESLint rule to disallow 'this' as the second argument to ChromeUtils.import.
(deleted),
text/x-phabricator-request
|
Details |
Callers should instead destructure the results of the import.
|
Assignee | |
Comment 1•4 years ago
|
||
I seem to have accidentally got sidetracked and have the majority of a patch for this.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D104683
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D104684
|
|
Assignee | |
Comment 5•4 years ago
|
||
I think my plan for this would be to land it after the code freeze for 87, i.e. at the start of 88. Although there's unlikely to be issues, I think landing at the start of a cycle is better for something like this.
|
||
Updated•4 years ago
|
Attachment #9202313 -
Attachment description: Bug 1608272 - ESLint automatic fixes to remove 'this' as the second argument of ChromeUtils.import. → Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r?Gijs
|
|
||
Updated•4 years ago
|
Attachment #9202315 -
Attachment description: Bug 1608272 - Manual fixes to remove 'this' as the second argument of ChromeUtils.import. → Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (application changes). r?Gijs
|
|
Assignee | |
Comment 6•4 years ago
|
||
|
|
||
Updated•4 years ago
|
Attachment #9202313 -
Attachment description: Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r?Gijs → Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r?Gijs!
|
|
||
Updated•4 years ago
|
Attachment #9202315 -
Attachment description: Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (application changes). r?Gijs → Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (application changes). r?Gijs!
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d15ecc335a7
Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
https://hg.mozilla.org/integration/autoland/rev/0248fb3e2f1c
Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (application changes). r=geckoview-reviewers,Gijs,agi
https://hg.mozilla.org/integration/autoland/rev/e6e4ffe379f1
Extend an ESLint rule to disallow 'this' as the second argument to ChromeUtils.import. r=Gijs
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2d15ecc335a7
https://hg.mozilla.org/mozilla-central/rev/0248fb3e2f1c
https://hg.mozilla.org/mozilla-central/rev/e6e4ffe379f1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
|
||
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•