Closed Bug 1608308 Opened 5 years ago Closed 5 years ago

add telemetry for libxul / omni.ja build ID matching to Corroborate.jsm

Categories

(Firefox :: General, task, P1)

Product:
Firefox
Component:
General
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(5 files, 1 obsolete file)

Bug 1608308 - Add telemetry to check that the libxul and omnijar build IDs match.
(deleted), text/x-phabricator-request
Details
data review request
(deleted), text/plain
chutten
: data-review+
Details
Bug 1608308 - Enable Corroborate.jsm telemetry on release.
(deleted), text/x-phabricator-request
Details
Bug 1608308 - re-enable corroborator tests
(deleted), text/x-phabricator-request
Details
Data Collection Renewal for Bug 1608308
(deleted), text/plain
chutten
: data-review+
Details

One possible cause of bug 1607716 is a version mismatch between libxul and the omni.ja. We can add some telemetry to check if that's the case.

Assignee: nobody → cam
Status: NEW → ASSIGNED
Attached file data review request (obsolete) (deleted) —
Attachment #9119956 - Flags: data-review?(chutten)

Oh, I should mention too that this is only enabled on Nightly currently:

https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1886

We can go ahead and enable it for beta/release now though, I have been meaning to and haven't gotten around to it yet.

Flags: needinfo?(cam)
Comment on attachment 9119956 [details] data review request Load-balancing to Megan.
Attachment #9119956 - Flags: data-review?(chutten) → data-review?(mmccorquodale)
Attached file data review request (deleted) —
Attachment #9119956 - Attachment is obsolete: true
Attachment #9119956 - Flags: data-review?(mmccorquodale)
Flags: needinfo?(cam)
Attachment #9120381 - Flags: data-review?(mmccorquodale)

And bump the expiration versions on the scalars.

BTW I was just looking over things, and as it happens we disabled the tests after the armagadd-on incident (waiting for the new signing cert to become available since the test uses it to make sure we don't count e.g. an omni jar signed with the AMO cert as valid). So here's a patch for re-enabling that, I don't want this to ride out w/o test coverage :)

Ping for data-review request.

Flags: needinfo?(mmccorquodale)
Attachment #9122609 - Flags: data-review?(chutten)
Comment on attachment 9122609 [details] Data Collection Renewal for Bug 1608308 Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward? Yes. Is the data collection covered by the existing Firefox Privacy Notice? Yes. --- Result: datareview+
Attachment #9122609 - Flags: data-review?(chutten) → data-review+
Priority: -- → P1
Comment on attachment 9120381 [details] data review request DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions file [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? No. This collection will expire in Firefox 80. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? Yes. :heycam is responsible for renewing or removing the collection before it expires in Firefox 80. --- Result: datareview+
Attachment #9120381 - Flags: data-review?(mmccorquodale) → data-review+
Flags: needinfo?(mmccorquodale)
Attachment #9120812 - Attachment description: Bug 1608308 - re-enable corroborator tests r?heycam → Bug 1608308 - re-enable corroborator tests
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4d8eb6905e1 Add telemetry to check that the libxul and omnijar build IDs match. r=rhelmer https://hg.mozilla.org/integration/autoland/rev/ce41f6059545 Enable Corroborate.jsm telemetry on release. r=rhelmer https://hg.mozilla.org/integration/autoland/rev/3239cb4f98c6 re-enable corroborator tests r=heycam

Filed bug 1614541 to investigate the results.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: