Closed Bug 1608579 Opened 5 years ago Closed 5 years ago

Disable double buffering on 72

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox72 + fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We want to do this because of bug 1608485

We have reports of 60fps video stutter caused by
double buffering so let's disable it until we can figure
out what's going on.

This is the same thing that landed in 71: 2dd6b102980e

Comment on attachment 9120201 [details]
Bug 1608579. Turn off double buffering in 72. a=lizzard

Beta/Release Uplift Approval Request

  • User impact if declined: 60fps video stutter
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Multiple reporters confirmed that disabling double-buffering helps with their problem.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is just reverting to the same behaviour we had in 71
  • String changes made/needed:
Attachment #9120201 - Flags: approval-mozilla-release?

Looking to get this into a potential 72.0.2 dot release.

Comment on attachment 9120201 [details]
Bug 1608579. Turn off double buffering in 72. a=lizzard

turn double buffering back off to fix video regression on some hw, approved for 72.0.2

Attachment #9120201 - Flags: approval-mozilla-release? → approval-mozilla-release+
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

Given where we are in the cycle, should we consider taking this on Beta for 73 as well?

Flags: needinfo?(jmuizelaar)

And possibly also trunk until there's a fix for bug 1608485?

We can uplift for 73 in bug 1610912

Flags: needinfo?(jmuizelaar)
Blocks: 1598126
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: