Closed Bug 1609100 Opened 5 years ago Closed 3 years ago

Remove unused about:devtools page

Categories

(DevTools :: Framework, task, P3)

Product:
DevTools
Component:
Framework
Type:
task

Tracking

(firefox100 fixed)

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Bug 1609100 - [devtools] Remove unused about:devtools page
(deleted), text/x-phabricator-request
Details
Bug 1609100 - Remove mentions of about:devtools from enterprisepolicies
(deleted), text/x-phabricator-request
Details
Bug 1609100 - Remove devtools.enabled check from Console.cpp
(deleted), text/x-phabricator-request
Details
Bug 1609100 - Remove devtools.enabled preference
(deleted), text/x-phabricator-request
Details
Bug 1609100 - Remove reference to aboutdevtools script in DOMSecurityMonitor.cpp
(deleted), text/x-phabricator-request
Details
Bug 1609100 - Remove reference to aboutdevtools in browser_check_identity_state.js
(deleted), text/x-phabricator-request
Details

Follow up to Bug 1519018. We removed all the code related to the onboarding experiment, but we still have the about:devtools page to remove.

Previous comment of mine on the other bug:

Had a quick look and the main issue here is that we have a significant amount of logic that supports "disabled devtools" (eg new menu item "Enable Developer Tools..."). So if we remove the about:devtools page, in theory we should remove everything that might lead to about:devtools, otherwise we will have dead code paths. But a lot of that might be reusable for future onboarding experiments, so I think it would be a waste to throw all the code away.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Framework

Blocking the new F12 work

Blocks: 1704519
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Depends on D141464

The about:devtools page is removed, we can remove it from the policy code.

Depends on D141467

The devtools.enabled preference was never really used in the end.
The devtools add-on plans were cancelled, as well as the devtools onboarding flows.

So I think this was essentially dead code.

Depends on D141468

All usage of this preference should now have been removed.
We don't plan to disable devtools completely, but only to disable the F12 shortcut.

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e59351660ab [devtools] Remove unused about:devtools page r=devtools-reviewers,fluent-reviewers,flod,nchevobbe https://hg.mozilla.org/integration/autoland/rev/e6ae2c01908e Remove mentions of about:devtools from enterprisepolicies r=mkaply https://hg.mozilla.org/integration/autoland/rev/e5c4afe5dd66 Remove devtools.enabled check from Console.cpp r=baku,nchevobbe https://hg.mozilla.org/integration/autoland/rev/e22daee724f0 Remove devtools.enabled preference r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/521cbbae0914 Remove reference to aboutdevtools script in DOMSecurityMonitor.cpp r=Gijs

Backed out for causing mochitest failures on browser_check_identity_state.js

Backout link

Push with failures

Failure log

Flags: needinfo?(jdescottes)

Ah looks like browser_check_identity_state.js is also testing about:devtools, but I missed it because it's not explicitly mentioning about:devtools. Need to remove the line at https://searchfox.org/mozilla-central/rev/b671b6390e88672543b9b7c82132be655bd98856/browser/base/content/test/siteIdentity/browser_check_identity_state.js#74

Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac717db869c6 [devtools] Remove unused about:devtools page r=devtools-reviewers,fluent-reviewers,flod,nchevobbe https://hg.mozilla.org/integration/autoland/rev/93e2497d5d88 Remove mentions of about:devtools from enterprisepolicies r=mkaply https://hg.mozilla.org/integration/autoland/rev/115f947f4f66 Remove devtools.enabled check from Console.cpp r=baku,nchevobbe https://hg.mozilla.org/integration/autoland/rev/a98b9f4a1d1c Remove devtools.enabled preference r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/b626dfc20682 Remove reference to aboutdevtools script in DOMSecurityMonitor.cpp r=Gijs https://hg.mozilla.org/integration/autoland/rev/968fbf6968d3 Remove reference to aboutdevtools in browser_check_identity_state.js r=Gijs
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/1e38a30eb589 Port bug 1609100 - Remove mentions of about:devtools from enterprisepolicies. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: