Closed Bug 1609462 Opened 5 years ago Closed 5 years ago

Small tweak to modal overlay

Categories

(Firefox :: New Tab Page, enhancement)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 74
Tracking Flags:
Tracking Status
firefox74 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

Details

Attachments

(1 file)

Bug 1609462 - working on modal overlay positioning
(deleted), text/x-phabricator-request
Details

Noticed working on another bug the modal overlay positioning might be able to be simplify a bit, by using flex and margin: auto to center it.

Assignee: nobody → sdowne
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/7fab57c31456 working on modal overlay positioning r=emcminn

https://hg.mozilla.org/mozilla-central/rev/7fab57c31456

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74

I have verified the welcome modal overlay and I can confirm the following:

  • display is set to flex;
  • positon is set to relative;
  • margin is set to auto;
  • overflow is set to auto;
  • z-index is set to 1100

Verified using latest Firefox Nightly (74.0a1 Build ID - 20200119213718) installed on Windows 10 x64, Mac 10.15.2, and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
status-firefox74: fixed → verified
No longer regressions: 1612108
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: