Closed Bug 160973 Opened 22 years ago Closed 21 years ago

gtk assertion on installer exit from auto-mode

Categories

(SeaMonkey :: Installer, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: ajschult784)

References

Details

Attachments

(1 file, 1 obsolete file)

When the running the installer in auto-mode (./mozilla-installer -ma), this message appears in my console when it finishes: Gtk-CRITICAL **: file gtkmain.c: line 582 (gtk_main_quit): assertion `main_loops != NULL' failed.
QA Contact: bugzilla → ktrina
Attached patch patch2 (obsolete) (deleted) — Splinter Review
normal mode fires off gtk_main() to run the wizard. auto mode does not. the gtk_main_quit() in ShowCompleteDlg() actually corresponds to that gtk_main() and should not be called for the auto mode. Closing out the wizard seems like something that should be done quite a bit upstream. I moved it to PerformInstall(), although it could probably go up farther.
Attachment #107671 - Flags: review?(sgehani)
reassign
Assignee: dveditz → ssu
Comment on attachment 107671 [details] [diff] [review] patch2 still looking for review-love
Attachment #107671 - Flags: review?(sgehani) → review?(ssu)
-> me
Assignee: ssu → ajschult
Blocks: 123569
Andrew: Do you work on linux installer bugs? Does this patch work in newer builds?
Attached patch patch3 (deleted) — Splinter Review
this implements my own suggestion about moving gtk_main_quit farther upstream. This patch just removes gtk_main_quit from ShowCompleteDlg and the check for bDLCancel (set when the download is cancelled). The check seems totally bogus because gtk_main is not called in relation to downloading the XPIs. I tested both normal and auto mode for the cases of: 1. cancelling the download 2. not cancelling the download 3. having the XPIs already downloaded all 6 tests were successful and no assertions.
Attachment #107671 - Attachment is obsolete: true
Attachment #140211 - Attachment is patch: true
Attachment #140211 - Flags: review?(dveditz+bmo)
Attachment #107671 - Flags: review?(ssu0262)
> Andrew: Do you work on linux installer bugs? if they're relatively simple. but someone has to review them.
QA Contact: ktrina → nobody
Comment on attachment 140211 [details] [diff] [review] patch3 r=dveditz
Attachment #140211 - Flags: review?(dveditz+bmo) → review+
Comment on attachment 140211 [details] [diff] [review] patch3 thanks dveditz! looking for more review-love.
Attachment #140211 - Flags: superreview?(bryner)
Attachment #140211 - Flags: superreview?(bryner) → superreview+
biesi: can you check in this patch? thanks!
Checking in nsInstallDlg.cpp; /cvsroot/mozilla/xpinstall/wizard/unix/src2/nsInstallDlg.cpp,v <-- nsInstallDlg.cpp new revision: 1.27; previous revision: 1.26 done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: