Remove Web Replay
Categories
(Core Graveyard :: Web Replay, task)
Tracking
(firefox75 fixed)
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: jlast)
References
(Blocks 1 open bug)
Details
(Whiteboard: [ci-costs-2020:done])
Attachments
(4 files, 1 obsolete file)
I was laid off yesterday, and web replay seems like it should be removed from the tree now. I will not be around/able to maintain it, so unless someone else wants to make the effort to maintain it, pretty soon it will break and stay broken.
The attached patch removes all the replay related code I could find, and applies onto 893e9fda4bf3. I can't break this up and submit it for review because my phabricator account has been disabled, so someone else will need to get this landed.
Reporter | ||
Comment 1•5 years ago
|
||
For anyone wondering, I will be forking Gecko and continuing to develop web replay in a new tree. I've started https://webreplay.org/ for this effort.
Reporter | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
I can try landing this.
I'm sorry to see you go Brian, but happy that users will have an opportunity to experience Web Replay in the near future.
Reporter | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
I'm sorry to hear that you are leaving, Brian. Good luck with your continuing work on Web Replay. It is really neat.
(In case you don't know, you can set Bugzilla to block needinfos of you.)
Comment 7•5 years ago
|
||
Thanks for all your work on this Brian. Watching you bring this from a crazy tech idea to this blazing-fast user-ready experience has been an amazing journey and I am honored that I could work with you on it.
It's Web Replay's nature to never go away but to evolve, so thanks for pushing on with it and best of luck!
Comment 8•5 years ago
|
||
r+ for my parts, but I'd like to see some management sign-off on ripping this out.
Comment 9•5 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #8)
r+ for my parts, but I'd like to see some management sign-off on ripping this out.
This sounds like a reasonable request. I'll see what Jason thinks about it.
Assignee | ||
Comment 10•5 years ago
|
||
I think that is reasonable.
Comment 11•5 years ago
|
||
It's sad to see this removal but, I think it's the right way to go so, OK for me.
Andrew can you please confirm?
Honza
Assignee | ||
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
Confirmed (and confirmed with a few others), thank you.
Updated•5 years ago
|
Comment 14•5 years ago
|
||
Comment 15•5 years ago
|
||
Backed out for build bustages at JSControl.cpp
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=286213282&resultStatus=testfailed%2Cbusted%2Cexception&revision=c41e5432b3c509f98e79af9e0e234e43ce02d02d
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286213282&repo=autoland&lineNumber=41011
Backout: https://hg.mozilla.org/integration/autoland/rev/1f891f357702b1d7016a61c8f4d84ff18cd46a6a
Comment 17•5 years ago
|
||
Jason: Please note that bug 1252803 just landed, so you'll have a little bitrot on the .eslintignore
file to update as well.
Comment 18•5 years ago
|
||
Comment 19•5 years ago
|
||
Backed out changeset cfe2388a674e (Bug 1609815) for causing TypeError in browserContext CLOSED TREE
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288267964&repo=autoland&lineNumber=13787
Backout: https://hg.mozilla.org/integration/autoland/rev/8e920c4afb281ad904a843d3fb3482fae273575c
Comment 20•5 years ago
|
||
Comment 21•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 22•5 years ago
|
||
Comment 23•5 years ago
|
||
Comment 24•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 25•5 years ago
|
||
== Change summary for alert #24935 (as of Fri, 14 Feb 2020 04:51:24 GMT) ==
Improvements:
0.21% installer size osx-shippable opt nightly 80,459,534.92 -> 80,294,078.50
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24935
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment 29•5 years ago
|
||
Does this still need to have leave-open?
Comment 30•5 years ago
|
||
(In reply to Andreea Pavel [:apavel] from comment #29)
Does this still need to have leave-open?
There's still a lot of Web Replay to be removed. The patch that landed only removed the JS part of it.
Comment 31•5 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #30)
(In reply to Andreea Pavel [:apavel] from comment #29)
Does this still need to have leave-open?
There's still a lot of Web Replay to be removed. The patch that landed only removed the JS part of it.
Oh okay, thanks.
Comment 32•5 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #30)
(In reply to Andreea Pavel [:apavel] from comment #29)
Does this still need to have leave-open?
There's still a lot of Web Replay to be removed. The patch that landed only removed the JS part of it.
Is it OK to land something that breaks WebReplay or removes some WebReplay calls at this time?
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 34•5 years ago
|
||
I've rebased the remainder of the patch.
Comment 35•5 years ago
|
||
Updated•5 years ago
|
Comment 36•5 years ago
|
||
Backed out changeset d407a28318e6 (bug 1609815) for causing windows ming bustages
https://hg.mozilla.org/integration/autoland/rev/6ea49052598fbebed1ed389269ab58ad91b53d2f
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=290711643&revision=d407a28318e68dd78af8365a1ea3f8f7384f92c5&failure_classification_id=2
Updated•5 years ago
|
Comment 37•5 years ago
|
||
netwerk/base/nsSocketTransportService2.h
is missing a #include <mozilla/Maybe.h>
. The Maybe
was introduced in bug 1596799.
Comment 38•5 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #37)
netwerk/base/nsSocketTransportService2.h
is missing a#include <mozilla/Maybe.h>
. TheMaybe
was introduced in bug 1596799.
Thanks, Mike. Yeah, a few places were bootlegging Maybe<> from WebReplay headers. I'll see if a Windows build finishes, then try to land it again.
Comment 39•5 years ago
|
||
Comment 40•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•