Port bug 1609271 to Thunderbird: Stop using ChromeUtils.import(..., null) which returns the global object for a module instead of its exports
Categories
(Thunderbird :: Upstream Synchronization, task, P3)
Tracking
(thunderbird_esr91 wontfix)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr91 | --- | wontfix |
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Port bug 1609271: Stop using ChromeUtils.import(..., null)
https://phabricator.services.mozilla.com/D60158 has a patch to enable an eslint rule to find offenders.
|
||
Comment 1•5 years ago
|
||
The linting rule just landed. There were 9 failures. I've fixed 6 and disabled the rule on the others in:
- mail/components/enterprisepolicies/tests/browser/browser_policies_setAndLockPref_API.js
- mail/components/enterprisepolicies/tests/xpcshell/test_proxy.js
- mail/components/enterprisepolicies/tests/xpcshell/test_runOnce_helper.js
We should wait and see what happens to the Firefox version of these files, then copy it.
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
Bug bug 1609271 isn't finished yet, so this is also not complete.
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
Port https://hg.mozilla.org/mozilla-central/rev/c4f862d825ca
Also port remaining parts of https://hg.mozilla.org/mozilla-central/rev/ec8d548769416dbf1aaaabb492dc85720c63ce20
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 5•3 years ago
|
||
https://hg.mozilla.org/comm-central/rev/2133b49b165b73d0dbc30385f951989bcc5a1610 fixed the remaining bits.
I'll update the patch to only have the pieces it did not cover
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
Description
•