Closed Bug 1610298 Opened 5 years ago Closed 5 years ago

Preview messages don't belong to a provider

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 74
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- wontfix
firefox74 --- fixed

People

(Reporter: andreio, Assigned: andreio)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1610298 - Snippets preview messages don't belong to a provider
(deleted), text/x-phabricator-request
Details

The preview flow is:

  1. Add preview provider
  2. Update all providers (fetch messages).
  • this removes the preview provider at the end
  1. Fetch messages that match message.provider === 'preview'
  • this would check for provider.excludes... but the preview provider was already removed
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/74c36888692b Snippets preview messages don't belong to a provider r=k88hudson

Backed out changeset 74c36888692b (Bug 1610298) for causing browser-chrome failures at browser/components/aboutlogins/tests/browser/browser_breachAlertShowingForAddedLogin.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=286711389&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-fis-e10s-4%2Cm-fis%28bc4%29&revision=74c36888692b70db45cc4c1f6d169e0ee5dd4747

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286709984&repo=autoland&lineNumber=7471

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-fis-e10s-4%2Cm-fis%28bc4%29&revision=39b86b7ed8bd2fc08b504c3d95d030f73fa3cb00

[task 2020-01-28T10:14:30.465Z] 10:14:30     INFO - ChromeMessagePort@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:197:5
[task 2020-01-28T10:14:30.465Z] 10:14:30     INFO - initPort@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:341:16
[task 2020-01-28T10:14:30.465Z] 10:14:30     INFO - MessageListener.receiveMessage*init@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:296:17
[task 2020-01-28T10:14:30.465Z] 10:14:30     INFO - @resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:350:27
[task 2020-01-28T10:14:30.465Z] 10:14:30     INFO - startup@resource://gre/modules/AddonManager.jsm:828:41
[task 2020-01-28T10:14:30.465Z] 10:14:30     INFO - startup@resource://gre/modules/AddonManager.jsm:3481:26
[task 2020-01-28T10:14:30.466Z] 10:14:30     INFO - observe@resource://gre/modules/addonManager.js:87:29
[task 2020-01-28T10:14:30.466Z] 10:14:30     INFO - 
[task 2020-01-28T10:14:30.466Z] 10:14:30     INFO - Buffered messages finished
[task 2020-01-28T10:14:30.466Z] 10:14:30     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_breachAlertShowingForAddedLogin.js | [JavaScript Error: "Unknown Collection "main/message-groups"" {file: "resource://services-settings/RemoteSettingsClient.jsm" line: 167}]
[task 2020-01-28T10:14:30.467Z] 10:14:30     INFO - UnknownCollectionError@resource://services-settings/RemoteSettingsClient.jsm:167:5
[task 2020-01-28T10:14:30.467Z] 10:14:30     INFO - sync@resource://services-settings/RemoteSettingsClient.jsm:403:13
[task 2020-01-28T10:14:30.467Z] 10:14:30     INFO - async*get@resource://services-settings/RemoteSettingsClient.jsm:349:22
[task 2020-01-28T10:14:30.467Z] 10:14:30     INFO - async*_getRemoteSettingsMessages@resource://activity-stream/lib/ASRouter.jsm:333:35
[task 2020-01-28T10:14:30.467Z] 10:14:30     INFO - _remoteSettingsLoader@resource://activity-stream/lib/ASRouter.jsm:283:45
[task 2020-01-28T10:14:30.467Z] 10:14:30     INFO - _loadDataForProvider@resource://activity-stream/lib/ASRouter.jsm:387:26
[task 2020-01-28T10:14:30.467Z] 10:14:30     INFO - loadMessagesForProvider@resource://activity-stream/lib/ASRouter.jsm:413:35
[task 2020-01-28T10:14:30.468Z] 10:14:30     INFO - loadMessagesFromAllProviders@resource://activity-stream/lib/ASRouter.jsm:814:40
[task 2020-01-28T10:14:30.468Z] 10:14:30     INFO - async*sendNewTabMessage@resource://activity-stream/lib/ASRouter.jsm:2032:16
[task 2020-01-28T10:14:30.468Z] 10:14:30     INFO - onMessage@resource://activity-stream/lib/ASRouter.jsm:2108:20
[task 2020-01-28T10:14:30.469Z] 10:14:30     INFO - Async*callListeners@resource://gre/modules/remotepagemanager/MessagePort.jsm:208:17
[task 2020-01-28T10:14:30.469Z] 10:14:30     INFO - portMessageReceived@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:94:19
[task 2020-01-28T10:14:30.469Z] 10:14:30     INFO - callListeners@resource://gre/modules/remotepagemanager/MessagePort.jsm:208:17
[task 2020-01-28T10:14:30.470Z] 10:14:30     INFO - handleMessage@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:267:19
[task 2020-01-28T10:14:30.470Z] 10:14:30     INFO - message@resource://gre/modules/remotepagemanager/MessagePort.jsm:375:10
[task 2020-01-28T10:14:30.470Z] 10:14:30     INFO - MessageListener.receiveMessage*addMessageListeners@resource://gre/modules/remotepagemanager/MessagePort.jsm:263:25
[task 2020-01-28T10:14:30.470Z] 10:14:30     INFO - MessagePort@resource://gre/modules/remotepagemanager/MessagePort.jsm:255:10
[task 2020-01-28T10:14:30.470Z] 10:14:30     INFO - ChromeMessagePort@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:197:5
[task 2020-01-28T10:14:30.471Z] 10:14:30     INFO - initPort@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:341:16
[task 2020-01-28T10:14:30.471Z] 10:14:30     INFO - MessageListener.receiveMessage*init@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:296:17
[task 2020-01-28T10:14:30.471Z] 10:14:30     INFO - @resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:350:27
[task 2020-01-28T10:14:30.472Z] 10:14:30     INFO - startup@resource://gre/modules/AddonManager.jsm:828:41
[task 2020-01-28T10:14:30.472Z] 10:14:30     INFO - startup@resource://gre/modules/AddonManager.jsm:3481:26
[task 2020-01-28T10:14:30.473Z] 10:14:30     INFO - observe@resource://gre/modules/addonManager.js:87:29
Flags: needinfo?(andrei.br92)
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28a9739ba4c4 Snippets preview messages don't belong to a provider r=k88hudson
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/309ae9c52ef1 Snippets preview messages don't belong to a provider r=k88hudson

*Backed out changeset 309ae9c52ef1 (bug 1610298) for causing browser_findbar.js to perma fail
It's caused browser_asrouter_snippets.js to permafail, the above was from another push.
https://hg.mozilla.org/integration/autoland/rev/4e3fa2f823f1d544f14d3aa8d5d79aff7779ff2f

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=309ae9c52ef150c21dd8329b23c3dfba54d77a13

Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30a1d14fe129 Snippets preview messages don't belong to a provider r=k88hudson

Trying to land again after a rewrite. Try run seems ok https://treeherder.mozilla.org/#/jobs?repo=try&revision=53b0aa8493c02de338e14f7a4104f08b88ca6ff6&selectedJob=287315196

Flags: needinfo?(andrei.br92)

https://hg.mozilla.org/mozilla-central/rev/30a1d14fe129

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: