Closed Bug 1610562 Opened 5 years ago Closed 5 years ago

Update inspect browser context functionality to take into account a potential list of remote targets.

Categories

(DevTools :: Framework, enhancement, P3)

enhancement

Tracking

(firefox78 fixed)

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

Attachments

(1 file)

Right now inspectNode and inspectA11Y assume a single walker front/actor when resolving a node front from a content DOM reference. This needs to be updated to take into account multiple walkers for various remote frames.

Julian, I have a patch however it still does not seem to work as is... I test it on https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe where I try to inspect a zoom in/zoom out button within the embedded map iframe which does not seem to work. getNodeActorFromContentDomReference returns null for all walkers...

Priority: -- → P3

The issue seems to be that the ContentDOMReference object for given walkers is not in the same content process as the one that was used to set targetIdentifier in the context menu..

Attachment #9122107 - Attachment description: Bug 1610562 - take into account multiple walker actors when getting a node from content DOM reference. r=jdescottes → Bug 1610562 - take into account multiple browsing contexts when getting a node from content DOM reference. r=jdescottes
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d3dc60cc5291 take into account multiple browsing contexts when getting a node from content DOM reference. r=jdescottes

Looks like there are unresolved dependencies for this landing , unless we land it under a pref. Will hold off for a little while.

Flags: needinfo?(yzenevich)
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/eadaf41bc8dc take into account multiple browsing contexts when getting a node from content DOM reference. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: