Update inspect browser context functionality to take into account a potential list of remote targets.
Categories
(DevTools :: Framework, enhancement, P3)
Tracking
(firefox78 fixed)
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: yzen, Assigned: yzen)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Right now inspectNode and inspectA11Y assume a single walker front/actor when resolving a node front from a content DOM reference. This needs to be updated to take into account multiple walkers for various remote frames.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Julian, I have a patch however it still does not seem to work as is... I test it on https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe where I try to inspect a zoom in/zoom out button within the embedded map iframe which does not seem to work. getNodeActorFromContentDomReference returns null for all walkers...
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
The issue seems to be that the ContentDOMReference object for given walkers is not in the same content process as the one that was used to set targetIdentifier in the context menu..
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Backed out changeset d3dc60cc5291 (bug 1610562) for devtools failures in browser_inspector_inspect_node_contextmenu.js
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286406012&repo=autoland&lineNumber=7513
Backout: https://hg.mozilla.org/integration/autoland/rev/e15adad7c221b40a0a06b805d4cbefab8f358f8b
Assignee | ||
Comment 6•5 years ago
|
||
Looks like there are unresolved dependencies for this landing , unless we land it under a pref. Will hold off for a little while.
Comment 8•5 years ago
|
||
bugherder |
Description
•