Implement XRInputSource
Categories
(Core :: WebVR, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: kip, Assigned: daoshengmu)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
Implement XRInputSource, as defined in the WebXR specification
Assignee | ||
Comment 2•5 years ago
|
||
OpenVR and Oculus controllers didn't provide targetRaySpace and gripSpace [1] info from their SDK. We only have controller pose that supposes to be grip space, however, it seems like still need a little bit offset to help the grip gesture could be put at the right position. In terms of target ray space, the only way we can do is tuning the position and hard-coded define it internally. It looks like it will happen similar issues like Gamepad API when handling btn and axis mapping in WebVR 1.0. For more wise approach, we should consider to move this information into profiles [2].
[1] https://immersive-web.github.io/webxr/#dom-xrinputsource-targetrayspace
[2] https://github.com/immersive-web/webxr-input-profiles/tree/master/packages/registry/profiles
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
I will keep working on Gamepad module for XRInputSource at Bug 1617023. I think It is ready to review once Bug 1614496 is landed.
Assignee | ||
Comment 5•5 years ago
|
||
MozReview-Commit-ID: 5pwtTYFawBk
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
I think it is good enough to review, and I will follow up other related bugs.
Comment 9•5 years ago
|
||
Backed out for build bustages.
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=296698848&resultStatus=testfailed%2Cbusted%2Cexception&revision=717f97c0d8719f0d92b3e5b4563c5c0c0998de09
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296698848&repo=autoland&lineNumber=37113
Backout: https://hg.mozilla.org/integration/autoland/rev/ab5d839fd72dc77633dc58103df5234ba645b1e0
Comment 10•5 years ago
|
||
Assignee | ||
Comment 11•5 years ago
|
||
(In reply to Razvan Maries from comment #9)
Backed out for build bustages.
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=296698848&resultStatus=testfailed%2Cbusted%2Cexception&revision=717f97c0d8719f0d92b3e5b4563c5c0c0998de09
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296698848&repo=autoland&lineNumber=37113
Backout: https://hg.mozilla.org/integration/autoland/rev/ab5d839fd72dc77633dc58103df5234ba645b1e0
It works if we land the patch of Bug 1627141 together.
I can move these few lines that cause compiling error to Bug 1627141.
Comment 12•5 years ago
|
||
bugherder |
Description
•