Closed Bug 1611310 Opened 5 years ago Closed 5 years ago

Implement XRInputSource

Categories

(Core :: WebVR, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: kip, Assigned: daoshengmu)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

Implement XRInputSource, as defined in the WebXR specification

I am going to help this.

Assignee: kgilbert → dmu

OpenVR and Oculus controllers didn't provide targetRaySpace and gripSpace [1] info from their SDK. We only have controller pose that supposes to be grip space, however, it seems like still need a little bit offset to help the grip gesture could be put at the right position. In terms of target ray space, the only way we can do is tuning the position and hard-coded define it internally. It looks like it will happen similar issues like Gamepad API when handling btn and axis mapping in WebVR 1.0. For more wise approach, we should consider to move this information into profiles [2].

[1] https://immersive-web.github.io/webxr/#dom-xrinputsource-targetrayspace
[2] https://github.com/immersive-web/webxr-input-profiles/tree/master/packages/registry/profiles

Attached file Bug 1611310 - Implement XRInputSource module. (obsolete) (deleted) —
Attachment #9126865 - Attachment description: Bug 1611310 - Implement XRInputSource API (wip). → Bug 1611310 - Implement XRInputSource module.

I will keep working on Gamepad module for XRInputSource at Bug 1617023. I think It is ready to review once Bug 1614496 is landed.

MozReview-Commit-ID: 5pwtTYFawBk

Attachment #9126865 - Attachment is obsolete: true

I think it is good enough to review, and I will follow up other related bugs.

Pushed by dmu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/717f97c0d871 Implement XRInputSource module. r=kip
Pushed by dmu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f1a8a490d36c Implement XRInputSource module. r=kip
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: