1611473 - mach jstestbrowser fails since bug 1596567 landed

Jon Coppeard (:jonco) (PTO until 14th September)

Reporter

Description

•

5 years ago

Since changeset bd9fd617d3c9 I get the following warning when running mach jstestbrowser:

REFTEST WARNING | runreftest.py | Failed to copy /home/jon/clone/bug/optdebug-dist-build/dist/test-stage/jsreftest/tests/user.js to profile

No tests are run.

Geoff Brown [:gbrown]

Comment 1

•

5 years ago

I can't think of why that would be, but will investigate as soon as I get a chance.

Assignee: nobody → gbrown

Priority: -- → P2

Geoff Brown [:gbrown]

Comment 2

•

5 years ago

Locally, I see:

$ ./mach jstestbrowser
 0:02.53 /usr/bin/make -j8 -s stage-jstests
 0:14.11 Elapsed: 11.47s; From _tests: Kept 18 existing; Added/updated 36981; Removed 0 files and 0 directories.
 0:14.13 make[1]: *** js/src/tests: No such file or directory.  Stop.
 0:14.13 /home/gbrown/src/testing/testsuite-targets.mk:195: recipe for target 'stage-jstests' failed
 0:14.13 make: *** [stage-jstests] Error 2
 0:14.15 300 compiler warnings present.
REFTEST WARNING | runreftest.py | Failed to copy /home/gbrown/objdirs/firefox/dist/test-stage/jsreftest/tests/user.js to profile
REFTEST INFO | Running with e10s: True
...

The js/src/tests reference reminds me of:
https://hg.mozilla.org/mozilla-central/rev/bd9fd617d3c9#l1.15

Geoff Brown [:gbrown]

Comment 3

•

5 years ago

~/objdirs/firefox$ make --trace stage-jstests
Makefile:118: target 'install-test-files' does not exist
/home/gbrown/objdirs/firefox/_virtualenvs/init/bin/python -m mozbuild.action.process_install_manifest --track install__test_files.track _tests _build_manifests/install/_test_files
Elapsed: 3.30s; From _tests: Kept 36914 existing; Added/updated 80; Removed 0 files and 0 directories.
/home/gbrown/src/testing/testsuite-targets.mk:174: update target 'make-stage-dir' due to: install-test-files
rm -rf dist/test-stage
./config/nsinstall -D dist/test-stage
./config/nsinstall -D dist/test-stage/bin
./config/nsinstall -D dist/test-stage/bin/components
./config/nsinstall -D dist/test-stage/certs
./config/nsinstall -D dist/test-stage/config
./config/nsinstall -D dist/test-stage/modules
./config/nsinstall -D dist/test-stage/tools/mach
/home/gbrown/src/testing/testsuite-targets.mk:195: update target 'stage-jstests' due to: make-stage-dir
make -C ./js/src/tests stage-package
make[1]: *** js/src/tests: No such file or directory.  Stop.
/home/gbrown/src/testing/testsuite-targets.mk:195: recipe for target 'stage-jstests' failed
make: *** [stage-jstests] Error 2

I find ~/objdirs/firefox/js/src exists but not ~/objdirs/firefox/js/src/tests.

Geoff Brown [:gbrown]

Comment 4

•

5 years ago

I tried backing out my change locally -- tests still did not run and I got the same "Failed to copy" message.

I updated to the push before bug 1596567, https://hg.mozilla.org/mozilla-central/rev/40f3654a935a8d60a0faa1faa5e29440a054dd8b, but tests still did not run and I got the same "Failed to copy" message:

gbrown@mozpad2:~/src$ ./mach jstestbrowser
 0:02.60 /usr/bin/make -j8 -s stage-jstests
 0:22.79 Elapsed: 20.03s; From _tests: Kept 36848 existing; Added/updated 80; Removed 0 files and 0 directories.
 0:22.80 make[1]: *** js/src/tests: No such file or directory.  Stop.
 0:22.80 /home/gbrown/src/testing/testsuite-targets.mk:195: recipe for target 'stage-jstests' failed
 0:22.80 make: *** [stage-jstests] Error 2
 0:22.82 300 compiler warnings present.
REFTEST WARNING | runreftest.py | Failed to copy /home/gbrown/objdirs/firefox/dist/test-stage/jsreftest/tests/user.js to profile
REFTEST INFO | Running with e10s: True
REFTEST INFO | Application command: /home/gbrown/objdirs/firefox/dist/bin/firefox -marionette -profile /tmp/tmpJ6G15O.mozrunner
1580996221192	addons.webextension.doh-rollout@mozilla.org	WARN	Loading extension 'doh-rollout@mozilla.org': Reading manifest: Invalid extension permission: networkStatus
1580996221268	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: mozillaAddons
1580996221268	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: telemetry
1580996221268	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: resource://pdf.js/
1580996221268	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: about:reader*
1580996221433	Marionette	TRACE	Received observer notification profile-after-change
1580996221508	Marionette	TRACE	Received observer notification command-line-startup
1580996221508	Marionette	DEBUG	Init aborted (running=false, enabled=true, finalUIStartup=false)
1580996221826	Marionette	TRACE	Received observer notification toplevel-window-ready
1580996223830	Marionette	TRACE	Received observer notification marionette-startup-requested
1580996223830	Marionette	TRACE	Waiting until startup recorder finished recording startup scripts...
1580996223876	Marionette	TRACE	All scripts recorded.
1580996223955	Marionette	INFO	Listening on port 2828
1580996223955	Marionette	DEBUG	Marionette is listening
1580996224043	Marionette	DEBUG	Accepted connection 0 from 127.0.0.1:47348
1580996224045	Marionette	DEBUG	Closed connection 0
1580996224045	Marionette	DEBUG	Accepted connection 1 from 127.0.0.1:47350
1580996224047	Marionette	DEBUG	1 -> [0,1,"WebDriver:NewSession",{"strictFileInteractability":true}]
1580996224087	Marionette	TRACE	[4] Frame script loaded
1580996224149	Marionette	TRACE	[4] Frame script registered
1580996224150	Marionette	TRACE	[24] Frame script loaded
1580996224175	Marionette	DEBUG	1 <- [1,1,null,{"sessionId":"02553719-1d6a-48c2-b4c1-87b8afdde98b","capabilities":{"browserName":"firefox","browserVersion":"74.0a ... mp/tmpJ6G15O.mozrunner","moz:shutdownTimeout":60000,"moz:useNonSpecCompliantPointerOrigin":false,"moz:webdriverClick":true}}]
1580996224176	Marionette	TRACE	[24] Frame script registered
1580996224191	Marionette	DEBUG	1 -> [0,2,"Addon:Install",{"path":"/home/gbrown/objdirs/firefox/dist/xpi-stage/specialpowers","temporary":true}]
1580996224210	Marionette	DEBUG	1 <- [1,2,null,{"value":"special-powers@mozilla.org"}]
1580996224216	Marionette	DEBUG	1 -> [0,3,"Addon:Install",{"path":"/home/gbrown/objdirs/firefox/dist/xpi-stage/reftest","temporary":true}]
1580996224243	Marionette	TRACE	Received observer notification toplevel-window-ready
1580996224245	Marionette	DEBUG	1 <- [1,3,null,{"value":"reftest@mozilla.org"}]
1580996224276	Marionette	TRACE	Received observer notification toplevel-window-ready
1580996224323	Marionette	DEBUG	1 -> [0,4,"WebDriver:DeleteSession",{}]
1580996224325	Marionette	DEBUG	1 <- [1,4,null,{"value":null}]
1580996224328	Marionette	DEBUG	Closed connection 1
REFTEST ERROR | Exactly one of reftest.manifests or reftest.tests must be specified.
REFTEST ERROR | reftest.tests is: null
REFTEST INFO | Slowest test took 0ms (undefined)
REFTEST INFO | Total canvas count = 0
1580996224790	Marionette	TRACE	Received observer notification xpcom-will-shutdown
1580996224790	Marionette	INFO	Stopped listening on port 2828
1580996224790	Marionette	DEBUG	Marionette stopped listening
REFTEST INFO | Process mode: e10s
leakcheck | refcount logging is off, so leaks can't be detected!
gbrown@mozpad2:~/src$ hg wip
...
@  509561:40f3654a935a aiakab Backed out 2 changesets (bug 1601688) for causing node-devtools failures.
~

It looks to me like jstestbrowser was busted before bug 1596567.

:jonco -- Is your experience different? How did you come to blame bug 1596567?

Flags: needinfo?(jcoppeard)

Jon Coppeard (:jonco) (PTO until 14th September)

Reporter

Comment 5

•

5 years ago

I also updated to the push before, but I reckon this is changeset b0ba506bd88d:

o  changeset:   509614:1984ce1fc774
|  user:        Olli Pettay <Olli.Pettay@helsinki.fi>
|  date:        Thu Jan 09 17:27:10 2020 +0000
|  summary:     Bug 1608093 - Remove support for multiple CycleCollectedJSContexts per CycleCollectedJSRuntime, r=mccr8
|
o  changeset:   509613:bd9fd617d3c9
|  user:        Geoff Brown <gbrown@mozilla.com>
|  date:        Thu Jan 09 19:25:58 2020 +0000
|  summary:     Bug 1596567 - Normalize test ids for reftests, crashtests, and jsreftests; r=ahal,jmaher
|
@  changeset:   509612:b0ba506bd88d
|  user:        Matt Brandt <mbrandt@mozilla.com>
|  date:        Thu Jan 09 20:26:09 2020 +0000
|  summary:     Bug 1608233 - [iris firefox] Update build to latest core version 0.8.5

I just tried this and the tests run for me at this changeset.

Flags: needinfo?(jcoppeard)

Geoff Brown [:gbrown]

Comment 6

•

5 years ago

Thanks. Yes b0ba506bd88d is the immediately previous changeset; 40f3654a935a is the previous m-c push (earlier).

I tried b0ba506bd88d, but I get the same errors:

gbrown@mozpad2:~/src$ ./mach jstestbrowser
 0:02.34 /usr/bin/make -j8 -s stage-jstests
 0:16.00 Elapsed: 13.55s; From _tests: Kept 18 existing; Added/updated 36914; Removed 0 files and 0 directories.
 0:16.02 make[1]: *** js/src/tests: No such file or directory.  Stop.
 0:16.02 /home/gbrown/src/testing/testsuite-targets.mk:195: recipe for target 'stage-jstests' failed
 0:16.02 make: *** [stage-jstests] Error 2
 0:16.06 300 compiler warnings present.
REFTEST WARNING | runreftest.py | Failed to copy /home/gbrown/objdirs/firefox/dist/test-stage/jsreftest/tests/user.js to profile
REFTEST INFO | Running with e10s: True
REFTEST INFO | Application command: /home/gbrown/objdirs/firefox/dist/bin/firefox -marionette -profile /tmp/tmpPkmZYW.mozrunner
1581006044909	addons.webextension.doh-rollout@mozilla.org	WARN	Loading extension 'doh-rollout@mozilla.org': Reading manifest: Invalid extension permission: networkStatus
1581006044983	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: mozillaAddons
1581006044983	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: telemetry
1581006044983	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: resource://pdf.js/
1581006044983	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: about:reader*
1581006045143	Marionette	TRACE	Received observer notification profile-after-change
1581006045271	Marionette	TRACE	Received observer notification command-line-startup
1581006045271	Marionette	DEBUG	Init aborted (running=false, enabled=true, finalUIStartup=false)
1581006045407	Marionette	TRACE	Received observer notification toplevel-window-ready
1581006047198	Marionette	TRACE	Received observer notification marionette-startup-requested
1581006047198	Marionette	TRACE	Waiting until startup recorder finished recording startup scripts...
1581006047327	Marionette	TRACE	All scripts recorded.
1581006047384	Marionette	INFO	Listening on port 2828
1581006047384	Marionette	DEBUG	Marionette is listening
1581006047481	Marionette	DEBUG	Accepted connection 0 from 127.0.0.1:49710
1581006047482	Marionette	DEBUG	Closed connection 0
1581006047482	Marionette	DEBUG	Accepted connection 1 from 127.0.0.1:49712
1581006047483	Marionette	DEBUG	1 -> [0,1,"WebDriver:NewSession",{"strictFileInteractability":true}]
1581006047520	Marionette	TRACE	[4] Frame script loaded
1581006047521	Marionette	TRACE	[4] Frame script registered
1581006047522	Marionette	TRACE	[24] Frame script loaded
1581006047531	Marionette	DEBUG	1 <- [1,1,null,{"sessionId":"d5286551-a9cb-40c8-a2f1-f055cdc24b11","capabilities":{"browserName":"firefox","browserVersion":"74.0a ... mp/tmpPkmZYW.mozrunner","moz:shutdownTimeout":60000,"moz:useNonSpecCompliantPointerOrigin":false,"moz:webdriverClick":true}}]
1581006047532	Marionette	TRACE	[24] Frame script registered
1581006047533	Marionette	DEBUG	1 -> [0,2,"Addon:Install",{"path":"/home/gbrown/objdirs/firefox/dist/xpi-stage/specialpowers","temporary":true}]
1581006047561	Marionette	DEBUG	1 <- [1,2,null,{"value":"special-powers@mozilla.org"}]
1581006047565	Marionette	DEBUG	1 -> [0,3,"Addon:Install",{"path":"/home/gbrown/objdirs/firefox/dist/xpi-stage/reftest","temporary":true}]
1581006047593	Marionette	TRACE	Received observer notification toplevel-window-ready
1581006047594	Marionette	DEBUG	1 <- [1,3,null,{"value":"reftest@mozilla.org"}]
1581006047615	Marionette	TRACE	Received observer notification toplevel-window-ready
1581006047653	Marionette	DEBUG	1 -> [0,4,"WebDriver:DeleteSession",{}]
1581006047654	Marionette	DEBUG	1 <- [1,4,null,{"value":null}]
1581006047659	Marionette	DEBUG	Closed connection 1
REFTEST ERROR | Exactly one of reftest.manifests or reftest.tests must be specified.
REFTEST ERROR | reftest.tests is: null
REFTEST INFO | Slowest test took 0ms (undefined)
REFTEST INFO | Total canvas count = 0
1581006048147	Marionette	TRACE	Received observer notification xpcom-will-shutdown
1581006048147	Marionette	INFO	Stopped listening on port 2828
1581006048147	Marionette	DEBUG	Marionette stopped listening
JavaScript error: resource://gre/modules/osfile/osfile_async_front.jsm, line 426: Error: OS.File has been shut down. Rejecting post to remove
JavaScript error: resource://gre/modules/osfile/osfile_async_front.jsm, line 426: Error: OS.File has been shut down. Rejecting post to remove
REFTEST INFO | Process mode: e10s
leakcheck | refcount logging is off, so leaks can't be detected!
gbrown@mozpad2:~/src$ hg wip
...
@  509612:b0ba506bd88d mbrandt Bug 1608233 - [iris firefox] Update build to latest core version 0.8.5
~

I am on Ubuntu 18, running a desktop build. It has been a long time since I tried running jstestbrowser -- maybe I am forgetting something simple?

Or maybe I should just concentrate on making this work, and forget about tracking down the regression....

Geoff Brown [:gbrown]

Comment 7

•

5 years ago

I tried running jsreftests from <topsrcdir>/js/src/tests, rather than the problematic staging/packaging to <objdir>/...; this doesn't work because the jstests.list manifest actually used to run tests is not <topsrcdir>/js/src/tests/jstests.list, but rather the jstests.list generated by jstests.py --make-manifests:

https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/js/src/tests/Makefile.in#27

Geoff Brown [:gbrown]

Updated

•

5 years ago

Whiteboard: dev-prod-2020

Geoff Brown [:gbrown]

Updated

•

5 years ago

Priority: P2 → P1

Geoff Brown [:gbrown]

Updated

•

5 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1626351

Bob Clary [:bc] (inactive)

Assignee

Comment 8

•

5 years ago

I have a patch that gets this to work for the desktop. I haven't looked at the android stuff yet though. Throw it my way if you want or let me know and I'll attach the wip for desktop.

Geoff Brown [:gbrown]

Comment 9

•

5 years ago

My initial efforts were fruitless and I am having trouble getting back to this. Any efforts you can make would be very much appreciated.

Assignee: gbrown → bob

Priority: P1 → P3

BugBot [:suhaib / :marco/ :calixte]

Updated

•

5 years ago

Keywords: regression

Bob Clary [:bc] (inactive)

Assignee

Comment 10

•

5 years ago

Attached file Bug 1611473 - fix desktop mach jstestbrowser by updating paths to test manifest and user.js after Bug 1596567, r=gbrown. (deleted) — Details

Bob Clary [:bc] (inactive)

Assignee

Comment 11

•

5 years ago

Attached file Bug 1611473 - fix mach reftest and mach jstestbrowser, r=gbrown. (deleted) — Details

update paths to test manifest and user.js after Bug 1596567.
fudge webserver url to work around difference in test paths.
make sure to use root=True when checking for existence of reftest.log.

Depends on D69312

Pulsebot

Comment 12

•

5 years ago

Pushed by bclary@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32e7a0782464 fix desktop mach jstestbrowser by updating paths to test manifest and user.js after Bug 1596567, r=gbrown.

Andreea Pavel [:apavel]

Comment 13

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/32e7a0782464

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox77: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla77

Ryan VanderMeulen [:RyanVM]

Updated

•

5 years ago

status-firefox74: --- → wontfix

status-firefox75: --- → wontfix

status-firefox76: --- → wontfix

status-firefox-esr68: --- → unaffected

Bob Clary [:bc] (inactive)

Assignee

Updated

•

5 years ago

Status: RESOLVED → REOPENED

Resolution: FIXED → ---

Bob Clary [:bc] (inactive)

Assignee

Updated

•

5 years ago

Depends on: 1631671

Phabricator Automation

Updated

•

5 years ago

Attachment #9137649 - Attachment description: Bug 1611473 - fix remote mach reftest and mach jstestbrowser, r=gbrown. → Bug 1611473 - fix mach reftest and mach jstestbrowser, r=gbrown.

Pulsebot

Comment 14

•

5 years ago

Pushed by bclary@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56f2759745c5 fix mach reftest and mach jstestbrowser, r=gbrown.

Oana Pop-Rus

Comment 15

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/56f2759745c5

Status: REOPENED → RESOLVED

Closed: 5 years ago → 5 years ago

Resolution: --- → FIXED

Bug 1611473 - fix desktop mach jstestbrowser by updating paths to test manifest and user.js after Bug 1596567, r=gbrown. 5 years ago Bob Clary [:bc] (inactive) (deleted), text/x-phabricator-request		Details
Bug 1611473 - fix mach reftest and mach jstestbrowser, r=gbrown. 5 years ago Bob Clary [:bc] (inactive) (deleted), text/x-phabricator-request		Details