Closed Bug 1611751 Opened 5 years ago Closed 5 years ago

Remove some nsIHTMLEditor, nsIEditorStyleSheets and nsITableEditor methods which are used by neither m-c, c-c nor BlueGriffon

Categories

(Core :: DOM: Editor, task, P5)

Product:
Core
Component:
DOM: Editor
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1611751 - Remove unused scriptable methods of `nsIHTMLEditor`, `nsIEditorStyleSheets` and `nsITableEditor` r=m_kato!
(deleted), text/x-phabricator-request
Details

+++ This bug was initially created as a clone of Bug #1610750 +++

Obviously, the following methods are not used by Gecko embedded products (I'm not sure about XUL addons for Thunderbird and SeaMonkey though).

  • nsIHTMLEditor.removeAllInlineProperties c-c BG
  • nsIHTMLEditor.increaseFontSize c-c BG
  • nsIHTMLEditor.decreaseFontSize c-c BG
  • nsIHTMLEditor.setParagraphFormat c-c BG
  • nsIHTMLEditor.getBackgroundColorState c-c BG (Used in C++ only only by m-c)
  • nsIHTMLEditor.indent c-c BG
  • nsIHTMLEditor.align c-c BG
  • nsIEditorStyleSheets.replaceOverrideStyleSheet c-c BG
  • nsITableEditor.selectBlockOfCells c-c BG

We should just remove them from these interfaces.

  • nsIHTMLEditor.removeAllInlineProperties
  • nsIHTMLEditor.increaseFontSize
  • nsIHTMLEditor.decreaseFontSize
  • nsIHTMLEditor.setParagraphFormat
  • nsIHTMLEditor.getBackgroundColorState
  • nsIHTMLEditor.indent
  • nsIHTMLEditor.align
  • nsIEditorStyleSheets.replaceOverrideStyleSheet
  • nsITableEditor.selectBlockOfCells

These methods are not used by any Gecko products including comm-central and
BlueGriffon so that we should remove them. Note that only
HTMLEditor::GetBackgroundColorState() is used internally so that we need to
keep it as a public method of HTMLEditor.

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/b6856377aa69 Remove unused scriptable methods of `nsIHTMLEditor`, `nsIEditorStyleSheets` and `nsITableEditor` r=m_kato

https://hg.mozilla.org/mozilla-central/rev/b6856377aa69

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: