On slower machines, the "Firefox Home Content" flickers when opening/reloading about:preferences#home
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: itiel_yn8)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
STR:
- Be on a somewhat slow machine
- Open about:preferences#home -- see the "Firefox Home Content" section flickers
- Reload and see the same thing
ER:
No flicker.
I think this happens because a margin-top: 14px; [1] rule is injected via JS.
|
||
Comment 1•5 years ago
|
||
Mardak, why is this CSS dynamically injected? Can we just add it to the "normal" CSS sheets?
|
|
||
Comment 2•5 years ago
|
||
(moving based on metadata for https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/AboutPreferences.jsm#59-61 which is doing this )
|
||
Comment 3•5 years ago
|
||
Now that newtab/ development happens directly from mozilla-central, I think it would be a good time to move this custom injected css into the normal way.
The attached patch fixes this, but I'm pretty sure I didn't to this right / I missed something.
Feel free to pick this up if you'd like.
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
The priority flag is not set for this bug.
:thecount, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Comment 7•4 years ago
|
||
:Mardak, I'm pretty sure this change doesn't block freezing the github repo. Can we remove that dep?
|
|
||
Updated•4 years ago
|
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e8ad5bbe739 Fix flickering of the "Firefox Home Content" section in about:preferences on slower machines r=Mardak
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
|
||
Comment 10•4 years ago
|
||
I have verified that the issue is no longer reproducible on the latest Firefox Nightly (75.0a1, BuildID 20200220093508) using Windows 10 x64, macOS 10.14, and Arch Linux 5.3.6. The "Firefox Home Content" section no longer flickers when the about:preferences#home page is loaded or refreshed.
Description
•