Closed Bug 1612242 Opened 5 years ago Closed 4 years ago

Replace idl nsIArray usage with Array<T> in ldap/xpcom/public

Categories

(MailNews Core :: General, task)

task
Not set
normal

Tracking

(thunderbird_esr78 wontfix, thunderbird84 wontfix)

RESOLVED FIXED
85 Branch
Tracking Status
thunderbird_esr78 --- wontfix
thunderbird84 --- wontfix

People

(Reporter: benc, Assigned: benc)

References

Details

(Keywords: leave-open)

Attachments

(3 files)

covers:

ldap/xpcom/public/nsILDAPModification.idl
ldap/xpcom/public/nsILDAPOperation.idl

searchfox query

Attachment #9189899 - Flags: review?(mkmelin+mozilla)
Attachment #9189900 - Flags: review?(mkmelin+mozilla)
Attachment #9189901 - Flags: review?(mkmelin+mozilla)

No test coverage on these yet, . Plan is to add some modification support to the fake LDAP server in Bug 662192 once it lands.
(But I've had these patches sitting around for a while, and they're fairly niche, so figured it'd be good to get them landed, even with the current lack of test coverage).

Keywords: leave-open
Comment on attachment 9189899 [details] [diff] [review] 1612242-part-one-remove-nsIArray-in-addExt-modifyExt-1.patch Review of attachment 9189899 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9189899 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → 85 Branch
Attachment #9189900 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9189901 - Flags: review?(mkmelin+mozilla) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/44a6e0d5804f
Remove nsIArray use in nsILDAPOperation.addExt() and .modifyExt(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/15c38bcd127f
Remove nsIArray use in nsILDAPOperation.serverControls and .clientControls. r=mkmelin
https://hg.mozilla.org/comm-central/rev/a05709be32dd
Remove nsIArray use in nsILDAPModification. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: