Closed
Bug 1612245
Opened 5 years ago
Closed 4 years ago
Replace idl nsIArray usage with Array<T> in nsIAutoSyncState.idl
Categories
(MailNews Core :: General, task)
MailNews Core
General
Tracking
(thunderbird_esr78 wontfix, thunderbird84 wontfix)
RESOLVED
FIXED
85 Branch
People
(Reporter: benc, Assigned: benc)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
mailnews/imap/public/nsIAutoSyncState.idl
|
Assignee | |
Comment 1•4 years ago
|
||
try run here:
Attachment #9190136 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9190136 [details] [diff] [review]
1612245-remove-nsIArray-from-nsIAutoSyncState-1.patch
Review of attachment 9190136 [details] [diff] [review]:
-----------------------------------------------------------------
::: mailnews/imap/src/nsAutoSyncState.cpp
@@ +669,3 @@
> while (x > toOffset && database) {
> x--;
> + if (q[x]) {
but there can be no null headers, right?
Attachment #9190136 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•4 years ago
|
Status: NEW → ASSIGNED
status-thunderbird84:
--- → wontfix
status-thunderbird_esr78:
--- → wontfix
Target Milestone: --- → 85 Branch
|
|
Assignee | |
Comment 3•4 years ago
|
||
> ::: mailnews/imap/src/nsAutoSyncState.cpp
> @@ +669,3 @@
> > while (x > toOffset && database) {
> > x--;
> > + if (q[x]) {
>
> but there can be no null headers, right?
There certainly shouldn't be, but a lot of code checks for it, so I'm not quite confident enough to remove these kinds of checks everywhere.
(The null checks we can remove are ones checking for missing nsIArray objects. No longer a problem if we're passing around nsTArray<> references instead of nsIArray*)
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed-tb
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8cf7a7a83d99
Remove nsIArray usage from nsIAutoSyncState. r=mkmelin
You need to log in
before you can comment on or make changes to this bug.
Description
•